[GitHub] [maven] eolivelli commented on a change in pull request #275: [MNG-6729] StringSearchModelInterpolator introspects objects from Java API

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #275: [MNG-6729] StringSearchModelInterpolator introspects objects from Java API
URL: https://github.com/apache/maven/pull/275#discussion_r311671554
 
 

 ##########
 File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
 ##########
 @@ -250,7 +250,13 @@ private static void evaluateArray( Object target, InterpolateObjectAction ctx )
 
             private boolean isQualifiedForInterpolation( Class<?> cls )
             {
-                return !cls.getName().startsWith( "java" );
+                Package pkg = cls.getPackage();
 
 Review comment:
   As you have the Class object.
   Will it make sense to exclude every system class, the ones loaded from the system classloader (class.getClassloader().getParent() == null) ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services