[GitHub] [airflow] mik-laj commented on a change in pull request #16849: Allow passing run_id to XCom.get_[one|many]

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #16849:
URL: https://github.com/apache/airflow/pull/16849#discussion_r665211694



##########
File path: airflow/models/xcom.py
##########
@@ -145,13 +150,16 @@ def get_many(
         dag_ids: Optional[Union[str, Iterable[str]]] = None,
         include_prior_dates: bool = False,
         limit: Optional[int] = None,
+        run_id: Optional[str] = None,
         session: Session = None,
     ) -> Query:
         """
         Composes a query to get one or more values from the xcom table.
 
         :param execution_date: Execution date for the task
         :type execution_date: pendulum.datetime
+        :param run_id: DagRun ID for the task
+        :type run_id: str

Review comment:
       Should we execution_date mark as a optional and add explicitly validation for required parameter - run_id or execution_date?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org