You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2016/03/19 08:27:25 UTC
spark git commit: [SPARK-14018][SQL] Use 64-bit num records in
BenchmarkWholeStageCodegen
Repository: spark
Updated Branches:
refs/heads/master b39594472 -> 1970d911d
[SPARK-14018][SQL] Use 64-bit num records in BenchmarkWholeStageCodegen
## What changes were proposed in this pull request?
500L << 20 is actually pretty close to 32-bit int limit. I was trying to increase this to 500L << 23 and got negative numbers instead.
## How was this patch tested?
I'm only modifying test code.
Author: Reynold Xin <rx...@databricks.com>
Closes #11839 from rxin/SPARK-14018.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/1970d911
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/1970d911
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/1970d911
Branch: refs/heads/master
Commit: 1970d911d91d7b53389629169e45bf33127ed2e8
Parents: b395944
Author: Reynold Xin <rx...@databricks.com>
Authored: Sat Mar 19 00:27:23 2016 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Sat Mar 19 00:27:23 2016 -0700
----------------------------------------------------------------------
.../spark/sql/execution/BenchmarkWholeStageCodegen.scala | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/1970d911/sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
index a16bd77..0b1cb90 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
@@ -42,7 +42,7 @@ class BenchmarkWholeStageCodegen extends SparkFunSuite {
lazy val sc = SparkContext.getOrCreate(conf)
lazy val sqlContext = SQLContext.getOrCreate(sc)
- def runBenchmark(name: String, values: Int)(f: => Unit): Unit = {
+ def runBenchmark(name: String, values: Long)(f: => Unit): Unit = {
val benchmark = new Benchmark(name, values)
Seq(false, true).foreach { enabled =>
@@ -57,7 +57,7 @@ class BenchmarkWholeStageCodegen extends SparkFunSuite {
// These benchmark are skipped in normal build
ignore("range/filter/sum") {
- val N = 500 << 20
+ val N = 500L << 20
runBenchmark("rang/filter/sum", N) {
sqlContext.range(N).filter("(id & 1) = 1").groupBy().sum().collect()
}
@@ -71,7 +71,7 @@ class BenchmarkWholeStageCodegen extends SparkFunSuite {
}
ignore("range/limit/sum") {
- val N = 500 << 20
+ val N = 500L << 20
runBenchmark("range/limit/sum", N) {
sqlContext.range(N).limit(1000000).groupBy().sum().collect()
}
@@ -85,7 +85,7 @@ class BenchmarkWholeStageCodegen extends SparkFunSuite {
}
ignore("stat functions") {
- val N = 100 << 20
+ val N = 100L << 20
runBenchmark("stddev", N) {
sqlContext.range(N).groupBy().agg("id" -> "stddev").collect()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org