You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/20 00:04:23 UTC

[GitHub] [iotdb] jixuan1989 commented on a change in pull request #1796: [IOTDB-886]fix float loss precision

jixuan1989 commented on a change in pull request #1796:
URL: https://github.com/apache/iotdb/pull/1796#discussion_r508130935



##########
File path: server/src/main/java/org/apache/iotdb/db/utils/TypeInferenceUtils.java
##########
@@ -63,6 +69,9 @@ public static TSDataType getPredictedDataType(Object value, boolean inferType) {
         return booleanStringInferType;
       } else if (isNumber(strValue)){
         if (!strValue.contains(TsFileConstant.PATH_SEPARATOR)) {
+          if (isConvertFloatPrecisionLack(strValue)) {

Review comment:
       how about just check the length of the string?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org