You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/12/13 14:10:30 UTC
[PR] docs(website): polish deploy to nightlies [incubator-opendal]
suyanhanx opened a new pull request, #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854014927
> Seems the rsync user can't mkdir...
Confirm this with Infra team?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854049000
> Doesn't work 😢 I'm going to create a ticket to infra team.
Wait a minute. Let me remove the `opendal` dir and try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854075849
Doesn't work ðŸ«
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1855548918
https://nightlies.apache.org/opendal/opendal-docs-stable/ looks cool, but https://nightlies.apache.org/opendal/opendal-docs-release-0.43.0/ is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854036805
Doesn't work 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#discussion_r1426718494
##########
website/docusaurus.config.js:
##########
@@ -24,6 +24,9 @@ const lightCodeTheme = require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const repoAddress = 'https://github.com/apache/incubator-opendal';
+const baseUrl = process.env.BASE_URL ? process.env.BASE_URL : '/';
Review Comment:
Please use `OPENDAL_WEBSITE_BASE_URL`.
##########
website/docusaurus.config.js:
##########
@@ -24,6 +24,9 @@ const lightCodeTheme = require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const repoAddress = 'https://github.com/apache/incubator-opendal';
+const baseUrl = process.env.BASE_URL ? process.env.BASE_URL : '/';
+const showAnnouncementBar = process.env.SHOW_ANNOUNCEMENT_BAR ? process.env.SHOW_ANNOUNCEMENT_BAR : false;
Review Comment:
Please use `OPENDAL_WEBSITE_SHOW_ANNOUNCEMENT_BAR`. By the way, the naming seems confusing. How about use `OPENDAL_WEBSITE_NOT_LATEST`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854018660
Flink works fine: https://github.com/apache/flink/blob/master/.github/workflows/docs.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#discussion_r1426807613
##########
website/docusaurus.config.js:
##########
@@ -24,6 +24,9 @@ const lightCodeTheme = require('prism-react-renderer/themes/github');
const darkCodeTheme = require('prism-react-renderer/themes/dracula');
const repoAddress = 'https://github.com/apache/incubator-opendal';
+const baseUrl = process.env.BASE_URL ? process.env.BASE_URL : '/';
+const showAnnouncementBar = process.env.SHOW_ANNOUNCEMENT_BAR ? process.env.SHOW_ANNOUNCEMENT_BAR : false;
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854057096
> > Doesn't work 😢 I'm going to create a ticket to infra team.
>
> Wait a minute. Let me remove the `opendal` dir and try again.
Seems that it would not create parent dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854013397
Seems the rsync user can't mkdir..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1854076953
Ticket created. https://issues.apache.org/jira/browse/INFRA-25275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(website): polish deploy to nightlies [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3753:
URL: https://github.com/apache/incubator-opendal/pull/3753#issuecomment-1855574212
https://nightlies.apache.org/opendal/opendal-docs-release-0.43.0/ is also ready! We can move on now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org