You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/15 13:59:09 UTC
[GitHub] [dubbo] zrlw opened a new issue #8813: 将ReferenceCountExchangeClient替换为LazyConnectExchangeClient时的告警机制设计不合理
zrlw opened a new issue #8813:
URL: https://github.com/apache/dubbo/issues/8813
### Environment
* Dubbo version: 3.0 / master
关闭ReferenceCountExchangeClient时，会调用replaceWithLazyClient将client替换为LazyConnectExchangeClient对象，但是执行替换的方法replaceWithLazyClient处理方式不合常理，首次关闭就告警safe guard client , should not be called ,must have a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed issue #8813: 将ReferenceCountExchangeClient替换为LazyConnectExchangeClient时的告警机制设计不合理
Posted by GitBox <gi...@apache.org>.
AlbumenJ closed issue #8813:
URL: https://github.com/apache/dubbo/issues/8813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw commented on issue #8813: 将ReferenceCountExchangeClient替换为LazyConnectExchangeClient时的告警机制设计不合理
Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8813:
URL: https://github.com/apache/dubbo/issues/8813#issuecomment-921607755
关闭ReferenceCountExchangeClient属于正常操作，不应该告警，替换为LazyConnectExchangeClient之后再次close才有必要告警。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw commented on issue #8813: 将ReferenceCountExchangeClient替换为LazyConnectExchangeClient时的告警机制设计不合理
Posted by GitBox <gi...@apache.org>.
zrlw commented on issue #8813:
URL: https://github.com/apache/dubbo/issues/8813#issuecomment-921611009
LazyConnectExchangeClient的单元测试代码也与现在的代码不一致，LazyConnectExchangeClient可能在最初的设计是复活就告警的，但现在复活LazyConnectExchangeClient并不会告警了，因为构建LazyConnectExchangeClient的代码设置REQUEST_WITH_WARNING_KEY告警参数的代码被注释掉了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw edited a comment on issue #8813: 将ReferenceCountExchangeClient替换为LazyConnectExchangeClient时的告警机制设计不合理
Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on issue #8813:
URL: https://github.com/apache/dubbo/issues/8813#issuecomment-921611009
LazyConnectExchangeClient的单元测试代码也与现在的代码不一致，LazyConnectExchangeClient可能在最初的设计是复活就告警的，但现在复活LazyConnectExchangeClient并不会告警了，因为现在的ReferenceCountExchangeClient在创建LazyConnectExchangeClient对象时注释掉了REQUEST_WITH_WARNING_KEY告警参数的设置。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org