You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/23 09:09:19 UTC

[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1940: [Api-draft] Add seatunnel kafka connector

ruanwenjun commented on code in PR #1940:
URL: https://github.com/apache/incubator-seatunnel/pull/1940#discussion_r879202904


##########
tools/dependencies/known-dependencies.txt:
##########
@@ -437,6 +437,7 @@ jsr311-api-1.1.1.jar
 jvm-attach-api-1.5.jar
 kafka-clients-2.0.0.jar
 kafka-clients-2.4.1.jar
+kafka-clients-3.2.0.jar

Review Comment:
   Can we unify the kafka-clients version? If you don't want to do this in this PR, you need to add announce in `LICENSE` file (NOTICE file it already contains this).
   The same goes to below newly dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org