You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/16 12:59:31 UTC
[GitHub] [incubator-kyuubi] byyue opened a new pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
byyue opened a new pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Close #1115.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116#discussion_r713758165
##########
File path: .github/ISSUE_TEMPLATE/bug-report.yml
##########
@@ -59,14 +59,24 @@ body:
validations:
required: true
+ - type: input
+ id: versions
+ attributes:
+ label: Affects Version(s)
+ description: Which versions of Kyuubi are affected by this bug?
+ placeholder: >
+ Latest/Stable/v1.1.0/From v1.0.0/All versions
Review comment:
can we use `e.g. master/1.3.0/1.2.0/...` in `placeholder` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116#issuecomment-924770282
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] byyue commented on a change in pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
byyue commented on a change in pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116#discussion_r713725979
##########
File path: .github/ISSUE_TEMPLATE/bug-report.yml
##########
@@ -59,14 +59,24 @@ body:
validations:
required: true
+ - type: input
+ id: versions
+ attributes:
+ label: Affects Version(s)
+ description: Which versions of Kyuubi are affected by this bug?
+ placeholder: >
+ Latest/Stable/v1.1.0/From v1.0.0/All versions
Review comment:
I initially considered using checkboxes but the list would become longer and longer as the number of versions increases. It might be better to let users describe this in plain text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116#discussion_r713694111
##########
File path: .github/ISSUE_TEMPLATE/bug-report.yml
##########
@@ -59,14 +59,24 @@ body:
validations:
required: true
+ - type: input
+ id: versions
+ attributes:
+ label: Affects Version(s)
+ description: Which versions of Kyuubi are affected by this bug?
+ placeholder: >
+ Latest/Stable/v1.1.0/From v1.0.0/All versions
Review comment:
Seems it's a little bit hard code to list all version, is it possible to show the existed branch list automatically ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116#issuecomment-920895104
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1116](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8357d4d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b6de06c5cc1d516188d0e5df1e393c93a7480772?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6de06c) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1116 +/- ##
============================================
- Coverage 79.22% 79.16% -0.07%
Complexity 87 87
============================================
Files 177 177
Lines 6598 6598
Branches 782 782
============================================
- Hits 5227 5223 -4
- Misses 919 924 +5
+ Partials 452 451 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `50.00% <0.00%> (-5.36%)` | :arrow_down: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `56.52% <0.00%> (-2.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b6de06c...8357d4d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1116?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] byyue commented on a change in pull request #1116: [KYUUBI #1115] Add Affects Version/s area in bug report issue template
Posted by GitBox <gi...@apache.org>.
byyue commented on a change in pull request #1116:
URL: https://github.com/apache/incubator-kyuubi/pull/1116#discussion_r713773747
##########
File path: .github/ISSUE_TEMPLATE/bug-report.yml
##########
@@ -59,14 +59,24 @@ body:
validations:
required: true
+ - type: input
+ id: versions
+ attributes:
+ label: Affects Version(s)
+ description: Which versions of Kyuubi are affected by this bug?
+ placeholder: >
+ Latest/Stable/v1.1.0/From v1.0.0/All versions
Review comment:
As you wish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org