You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2008/09/04 15:55:44 UTC
[jira] Created: (THRIFT-131) Add convenience counter methods to
fb303 thrift file
Add convenience counter methods to fb303 thrift file
----------------------------------------------------
Key: THRIFT-131
URL: https://issues.apache.org/jira/browse/THRIFT-131
Project: Thrift
Issue Type: Improvement
Reporter: Johan Oskarsson
Priority: Trivial
Since most of the different FacebookBase classes/files have a version of these methods, I suggest adding them to the fb303.thrift file.
/**
* increment this counter by 1
*/
i64 incrementCounter(String key);
/**
* Remove this counter and any value associated with it
*/
void deleteCounter(string key);
/**
* Reset this counter to 0
*/
void resetCounter(string key);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-131) Add convenience counter methods to
fb303 thrift file
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628341#action_12628341 ]
Johan Oskarsson commented on THRIFT-131:
----------------------------------------
Description got mangled, but you get my point.
I'll hope to have some time to implement this, but wanted to know if this goes against some thrift "keep it clean"-policy before I start.
Alternative to i64 incrementCounter(string key) would be: i64 incrementCounter(string key, i64 increment);
> Add convenience counter methods to fb303 thrift file
> ----------------------------------------------------
>
> Key: THRIFT-131
> URL: https://issues.apache.org/jira/browse/THRIFT-131
> Project: Thrift
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Priority: Trivial
>
> Since most of the different FacebookBase classes/files have a version of these methods, I suggest adding them to the fb303.thrift file.
> /**
> * increment this counter by 1
> */
> i64 incrementCounter(String key);
> /**
> * Remove this counter and any value associated with it
> */
> void deleteCounter(string key);
> /**
> * Reset this counter to 0
> */
> void resetCounter(string key);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-131) Add convenience counter methods to
fb303 thrift file
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628418#action_12628418 ]
David Reiss commented on THRIFT-131:
------------------------------------
I don't think there is any problem with this, but the purpose of those methods is more for internal use by the server. The counters are supposed to be read-only from the outside world.
> Add convenience counter methods to fb303 thrift file
> ----------------------------------------------------
>
> Key: THRIFT-131
> URL: https://issues.apache.org/jira/browse/THRIFT-131
> Project: Thrift
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Priority: Trivial
>
> Since most of the different FacebookBase classes/files have a version of these methods, I suggest adding them to the fb303.thrift file.
> /**
> * increment this counter by 1
> */
> i64 incrementCounter(String key);
> /**
> * Remove this counter and any value associated with it
> */
> void deleteCounter(string key);
> /**
> * Reset this counter to 0
> */
> void resetCounter(string key);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.