You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/27 13:49:13 UTC
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1916: HIVE-24691: Ban commons-logging (again)
kgyrtkirk commented on a change in pull request #1916:
URL: https://github.com/apache/hive/pull/1916#discussion_r565321370
##########
File path: pom.xml
##########
@@ -1360,6 +1360,13 @@
</bannedImports>
<includeTestCode>true</includeTestCode>
</restrictImports>
+ <restrictImports implementation="de.skuzzle.enforcer.restrictimports.RestrictImports">
+ <reason>Do not use commons-logging; use slf4j</reason>
+ <bannedImports>
+ <bannedImport>org.apache.commons.logging.**</bannedImport>
Review comment:
what do you think about `org.apache.log4j`? is that okay to use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org