[jira] [Commented] (FLINK-5532) Make the marker WindowAssigners for the fast aligned windows non-extendable.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831900#comment-15831900 ] 

ASF GitHub Bot commented on FLINK-5532:
---------------------------------------

GitHub user kl0u opened a pull request:

    https://github.com/apache/flink/pull/3180

    [FLINK-5532] Make window assigners for aligned window operators non-extendable

    Makes the TumblingAlignedProcessingTimeWindows and the
    SlidingAlignedProcessingTimeWindows final so that users cannot
    extend them.
    
    R @aljoscha @StephanEwen 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kl0u/flink non-extendable-aligned

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3180
    
----
commit 82bb3519e5bb024774795adcded0a51d9bc2fa4c
Author: kl0u <kk...@gmail.com>
Date:   2017-01-20T13:31:48Z

    [FLINK-5532] Make window assigners for aligned window ops non-extendable
    
    Makes the TumblingAlignedProcessingTimeWindows and the
    SlidingAlignedProcessingTimeWindows final so that users cannot
    extend them.

----


> Make the marker WindowAssigners for the fast aligned windows non-extendable.
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-5532
>                 URL: https://issues.apache.org/jira/browse/FLINK-5532
>             Project: Flink
>          Issue Type: Bug
>          Components: Windowing Operators
>    Affects Versions: 1.2.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.2.0
>
>
> This issue refers to the {{SlidingAlignedProcessingTimeWindows}} and {{TumblingAlignedProcessingTimeWindows}} and proposes to:
> (1) make the classes {{final}}
> (2) use {{getClass()}} for the check, not {{instanceof()}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)