You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/05 20:40:43 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #2226: xtensa/esp32: Avoid init PSRAM when SPIRAM is not enabled and fix remaining SEPARATE typo
acassis opened a new pull request #2226:
URL: https://github.com/apache/incubator-nuttx/pull/2226
## Summary
Avoid init PSRAM when SPIRAM is not enabled and fix remaining SEPARATE typo
## Impact
Protect against wrong configuration
## Testing
esp32-core
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2226: xtensa/esp32: Avoid init PSRAM when SPIRAM is not enabled and fix remaining SEPARATE typo
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2226:
URL: https://github.com/apache/incubator-nuttx/pull/2226#discussion_r518410358
##########
File path: arch/xtensa/src/common/xtensa_initialize.c
##########
@@ -150,7 +150,7 @@ void up_initialize(void)
/* Initialize the internal heap */
-#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
+#ifdef CONFIG_XTENSA_USE_SEPARATE_IMEM
Review comment:
I'm pretty sure I fixed these typos in a previous PR, why are they here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2226: xtensa/esp32: Avoid init PSRAM when SPIRAM is not enabled and fix remaining SEPARATE typo
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2226:
URL: https://github.com/apache/incubator-nuttx/pull/2226#discussion_r518415887
##########
File path: arch/xtensa/src/esp32/esp32_allocateheap.c
##########
@@ -93,7 +93,7 @@ void up_allocate_heap(FAR void **heap_start, size_t *heap_size)
*
****************************************************************************/
-#if CONFIG_MM_REGIONS > 1
+#if CONFIG_MM_REGIONS > 1 && defined(CONFIG_ESP32_SPIRAM)
Review comment:
```suggestion
#if CONFIG_MM_REGIONS > 1
```
This is what's breaking the build.
This condition should be moved to the line bellow where the PSRAM region is actually added.
##########
File path: arch/xtensa/src/common/xtensa_initialize.c
##########
@@ -150,7 +150,7 @@ void up_initialize(void)
/* Initialize the internal heap */
-#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
+#ifdef CONFIG_XTENSA_USE_SEPARATE_IMEM
Review comment:
It looks like I either missed some or didn't commit some. Either case I'm confused how it happened. Anyway, thanks for fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2226: xtensa/esp32: Avoid init PSRAM when SPIRAM is not enabled and fix remaining SEPARATE typo
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2226:
URL: https://github.com/apache/incubator-nuttx/pull/2226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org