You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/19 22:22:40 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395352595
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -184,13 +184,11 @@ def task_info(dag_id, task_id):
     return jsonify(fields)
 
 
-# ToDo: Shouldn't this be a PUT method?
-@api_experimental.route('/dags/<string:dag_id>/paused/<string:paused>', methods=['GET'])
+@api_experimental.route('/dags/<string:dag_id>/pause/<string:pause_state>', methods=['POST'])
 
 Review comment:
   @kaxil Why paused? It seems if we are asking it to do a thing that should be in present tense, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services