You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Peter Vary <pv...@cloudera.com> on 2016/10/18 07:02:38 UTC
Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/
-----------------------------------------------------------
Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
Bugs: HIVE-14459
https://issues.apache.org/jira/browse/HIVE-14459
Repository: hive-git
Description
-------
Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
- Enabled the driver
- Modified the regexps to hide when comparing the results
- Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
- Added required dependencies to pom
- Added specific results dir for beeline q.out-s
Diffs
-----
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
itests/src/test/resources/testconfiguration.properties 97e310d
itests/util/pom.xml 6d93dc1
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/52978/diff/
Testing
-------
Manually on my computer several runs.
Waiting for the QA tests
Thanks,
Peter Vary
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review153051
-----------------------------------------------------------
Ship it!
Thanks for the patch. +1
- Barna Zsombor Klara
On Oct. 18, 2016, 7:02 a.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 7:02 a.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 10:28 a.m.)
Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
Changes
-------
Changes:
- cleanupLocalDirOnStartup is true
- Added the script directory the the init scripts, so they should be running now
Bugs: HIVE-14459
https://issues.apache.org/jira/browse/HIVE-14459
Repository: hive-git
Description
-------
Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
- Enabled the driver
- Modified the regexps to hide when comparing the results
- Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
- Added required dependencies to pom
- Added specific results dir for beeline q.out-s
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
itests/src/test/resources/testconfiguration.properties d344464
itests/util/pom.xml 6d93dc1
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java af8ec67
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/52978/diff/
Testing
-------
Manually on my computer several runs.
Waiting for the QA tests
Thanks,
Peter Vary
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166945
-----------------------------------------------------------
LGTM (non-binding). Just one comment below. Thanks Peter!
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (line 76)
<https://reviews.apache.org/r/52978/#comment239036>
we should probably use cleanupLocalDirOnStartup(true) here. As a part of fixing flaky tests work, this flag was set to true for the other tests
- Vihang Karajgaonkar
On Feb. 24, 2017, 12:21 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 12:21 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java
> itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/src/test/resources/testconfiguration.properties d344464
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java af8ec67
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 12:21 p.m.)
Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
Changes
-------
Addressed Vihang's comments.
Moved from HiveServer2 to MiniHS2 as a server - this caused some refactoring.
Removed Zookeeper cluster creation but kept it commented out so we can enable it if needed
Added the possibility to change the init/cleanup scripts for the QFileClient
Added some comments
Bugs: HIVE-14459
https://issues.apache.org/jira/browse/HIVE-14459
Repository: hive-git
Description
-------
Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
- Enabled the driver
- Modified the regexps to hide when comparing the results
- Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
- Added required dependencies to pom
- Added specific results dir for beeline q.out-s
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
itests/src/test/resources/testconfiguration.properties d344464
itests/util/pom.xml 6d93dc1
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java af8ec67
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/52978/diff/
Testing
-------
Manually on my computer several runs.
Waiting for the QA tests
Thanks,
Peter Vary
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java, line 125
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541458#file1541458line125>
> >
> > can you please add a comment saying what the filter regex is doing to make it easier to understand?
>
> Peter Vary wrote:
> Will do - This is for removing the timestamp from the begining of the log lines
Done
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, lines 66-68
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line66>
> >
> > Not sure why we need this? Can you please add some comment to help us understand
>
> Peter Vary wrote:
> To be honest, I was aiming for the minimal change, and did not try to run without it. Will check - my guess is that the HiveServer configured to use ZK cluster for something.
>
> Peter Vary wrote:
> Ok.. Checked, and this is needed if we want to run HiveServer2 with ZookeeperLockManager. What do you think shall we use EmbeddedLockManager instead?
Commented out, but kept the code, so we can reenable it in time
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, lines 81-86
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line81>
> >
> > Is it possible to use miniHS2 instead?
>
> Peter Vary wrote:
> This is a very good idea! I think we should do that...
> The same applies here as above - tried to keep my changes minimal - Shall we change this here, or in a followup jira to separate the changes?
>
> Peter Vary wrote:
> Checked this, using miniHS2 would mean circular dependency. We have to move the CoreBeeLineDriver to hive-unit module to remove this problem. I think I will ask Zoltan what does he think about the refactor
Created a refactored version, I still think this a very good idea.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------
On Feb. 24, 2017, 12:21 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 12:21 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java
> itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/src/test/resources/testconfiguration.properties d344464
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java af8ec67
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, lines 66-68
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line66>
> >
> > Not sure why we need this? Can you please add some comment to help us understand
>
> Peter Vary wrote:
> To be honest, I was aiming for the minimal change, and did not try to run without it. Will check - my guess is that the HiveServer configured to use ZK cluster for something.
Ok.. Checked, and this is needed if we want to run HiveServer2 with ZookeeperLockManager. What do you think shall we use EmbeddedLockManager instead?
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------
On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2016, 1:39 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, line 116
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line116>
> >
> > Having a fixed port number could become a problem in ptests. May be we should use a port number which is available in the run time (I think miniHS2 instantiates on a available port at the run time)
>
> Peter Vary wrote:
> As above :)
We can do it in another JIRA as well. My guess is that if we use fixed ports it is more likely that this test will fail when we run it in pre-commit job due to parallel execution of batches.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------
On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2016, 1:39 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, lines 81-86
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line81>
> >
> > Is it possible to use miniHS2 instead?
>
> Peter Vary wrote:
> This is a very good idea! I think we should do that...
> The same applies here as above - tried to keep my changes minimal - Shall we change this here, or in a followup jira to separate the changes?
Checked this, using miniHS2 would mean circular dependency. We have to move the CoreBeeLineDriver to hive-unit module to remove this problem. I think I will ask Zoltan what does he think about the refactor
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------
On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2016, 1:39 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java, line 125
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541458#file1541458line125>
> >
> > can you please add a comment saying what the filter regex is doing to make it easier to understand?
Will do - This is for removing the timestamp from the begining of the log lines
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, lines 66-68
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line66>
> >
> > Not sure why we need this? Can you please add some comment to help us understand
To be honest, I was aiming for the minimal change, and did not try to run without it. Will check - my guess is that the HiveServer configured to use ZK cluster for something.
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, lines 81-86
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line81>
> >
> > Is it possible to use miniHS2 instead?
This is a very good idea! I think we should do that...
The same applies here as above - tried to keep my changes minimal - Shall we change this here, or in a followup jira to separate the changes?
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, line 116
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line116>
> >
> > Having a fixed port number could become a problem in ptests. May be we should use a port number which is available in the run time (I think miniHS2 instantiates on a available port at the run time)
As above :)
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------
On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2016, 1:39 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java (line 125)
<https://reviews.apache.org/r/52978/#comment237928>
can you please add a comment saying what the filter regex is doing to make it easier to understand?
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (lines 62 - 64)
<https://reviews.apache.org/r/52978/#comment237931>
Not sure why we need this? Can you please add some comment to help us understand
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (lines 77 - 82)
<https://reviews.apache.org/r/52978/#comment237929>
Is it possible to use miniHS2 instead?
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (line 112)
<https://reviews.apache.org/r/52978/#comment237930>
Having a fixed port number could become a problem in ptests. May be we should use a port number which is available in the run time (I think miniHS2 instantiates on a available port at the run time)
- Vihang Karajgaonkar
On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2016, 1:39 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/
-----------------------------------------------------------
(Updated Oct. 19, 2016, 1:39 p.m.)
Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
Changes
-------
2 if statements are merged when generating the diff command
Bugs: HIVE-14459
https://issues.apache.org/jira/browse/HIVE-14459
Repository: hive-git
Description
-------
Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
- Enabled the driver
- Modified the regexps to hide when comparing the results
- Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
- Added required dependencies to pom
- Added specific results dir for beeline q.out-s
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
itests/src/test/resources/testconfiguration.properties 97e310d
itests/util/pom.xml 6d93dc1
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/52978/diff/
Testing
-------
Manually on my computer several runs.
Waiting for the QA tests
Thanks,
Peter Vary
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 2:54 p.m.)
Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
Changes
-------
Updated the diff algorithm, so the diff results are printed not just an unhelpfull yes/no.
Hidden an asynchronous log message.
Bugs: HIVE-14459
https://issues.apache.org/jira/browse/HIVE-14459
Repository: hive-git
Description
-------
Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
- Enabled the driver
- Modified the regexps to hide when comparing the results
- Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
- Added required dependencies to pom
- Added specific results dir for beeline q.out-s
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
itests/src/test/resources/testconfiguration.properties 97e310d
itests/util/pom.xml 6d93dc1
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/52978/diff/
Testing
-------
Manually on my computer several runs.
Waiting for the QA tests
Thanks,
Peter Vary
Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
re-enable
Posted by Zoltan Haindrich <ki...@rxd.hu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review153046
-----------------------------------------------------------
Ship it!
Hello Peter!
Beeline tests are coming back into business? That's great! ;)
I think its a good idea to add just one case for now - that way we can ensure that its in working order; its a big step forward from not running any of them.
cheers,
Zoltan
- Zoltan Haindrich
On Oct. 18, 2016, 7:02 a.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 7:02 a.m.)
>
>
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-14459
> https://issues.apache.org/jira/browse/HIVE-14459
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6
> itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION
> itests/src/test/resources/testconfiguration.properties 97e310d
> itests/util/pom.xml 6d93dc1
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3
> ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52978/diff/
>
>
> Testing
> -------
>
> Manually on my computer several runs.
> Waiting for the QA tests
>
>
> Thanks,
>
> Peter Vary
>
>