You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/08 17:59:54 UTC
[GitHub] [camel] essobedo opened a new pull request, #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
essobedo opened a new pull request, #9016:
URL: https://github.com/apache/camel/pull/9016
Fixes https://issues.apache.org/jira/browse/CAMEL-18864
## Motivation
I think we can remove the .class also in camel core for `java-joor` dsl as it is not really needed anymore. I think (I am getting older so it is maybe no longer there) there is an option in camel-main to configure a "compile directory" so removing would also need to remove that.
## Modifications
* Remove the `ClassRoutesBuilderLoader`
* Remove "compile directory" and "compile load first" everywhere it is defined and used
* Remove all related unit tests
* Add a note in the upgrade guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #9016:
URL: https://github.com/apache/camel/pull/9016#issuecomment-1376037410
@davsclaus I can't see it in camel spring boot, could you please share with me a link to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9016:
URL: https://github.com/apache/camel/pull/9016#issuecomment-1374903891
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9016:
URL: https://github.com/apache/camel/pull/9016#issuecomment-1374905052
I think the option is also in camel spring boot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9016:
URL: https://github.com/apache/camel/pull/9016#issuecomment-1374892287
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #9016:
URL: https://github.com/apache/camel/pull/9016#issuecomment-1375208235
The checkstyle issue is not related to those changes, the problem is in `camel-jbang-core`:
```
[camel-jbang-core] [INFO] Starting audit...
[ERROR] /home/runner/work/camel/camel/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java:270:5: Method run length is 253 lines (max allowed is 250). [MethodLength]
Audit done.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
essobedo merged PR #9016:
URL: https://github.com/apache/camel/pull/9016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9016: CAMEL-18864: java-joor-dsl - Drop support of class files
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9016:
URL: https://github.com/apache/camel/pull/9016#issuecomment-1376042491
Ah yeah its not in spring boot as it was only needed via standalone via camel-main / jbang at the time. So this is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org