svn commit: r1067714 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

[st...@apache.org]

Author: stefan2
Date: Sun Feb  6 18:08:05 2011
New Revision: 1067714

URL: http://svn.apache.org/viewvc?rev=1067714&view=rev
Log:
Use svn_cstring_atoui64() to parse and validate module parameters.

* subversion/mod_dav_svn/mod_dav_svn.c
  (parse_number): drop
  (SVNInMemoryCacheSize_cmd): use svn_cstring_atoui64

Suggested by: stsp

Modified:
    subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

Modified: subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c?rev=1067714&r1=1067713&r2=1067714&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c Sun Feb  6 18:08:05 2011
@@ -420,25 +420,18 @@ SVNSpecialURI_cmd(cmd_parms *cmd, void *
   return NULL;
 }
 
-static apr_uint64_t
-parse_number(const char *arg)
-{
-  const char *c;
-  for (c = arg; *c != 0; ++c)
-    if (!svn_ctype_isdigit (*c))
-      return (apr_uint64_t)(-1);
-
-  return apr_strtoi64(arg, NULL, 0);
-}
-
 static const char *
 SVNInMemoryCacheSize_cmd(cmd_parms *cmd, void *config, const char *arg1)
 {
   svn_fs_cache_config_t settings = *svn_fs_get_cache_config();
 
-  apr_uint64_t value = parse_number(arg1);
-  if (value == (apr_uint64_t)(-1))
-    return "Invalid decimal number for the SVN cache size.";
+  apr_uint64_t value = 0;
+  svn_error_t *err = svn_cstring_atoui64(&value, arg1);
+  if (err)
+    {
+      svn_error_clear(err);
+      return "Invalid decimal number for the SVN cache size.";
+    }
 
   settings.cache_size = value * 0x100000;