You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/03 16:34:55 UTC

[GitHub] [submarine] joshvictor1024 edited a comment on pull request #816: SUBMARINE-1110. Add yaml linter or formatter

joshvictor1024 edited a comment on pull request #816:
URL: https://github.com/apache/submarine/pull/816#issuecomment-985657249


   @KUAN-HSUN-LI thanks for the review.
   
   1. Yes. The outputs are now properly formatted and can be seen at Actions > Check Style > View raw logs. Do ctrl+F for `.github` to see warnings regarding those files.
   2.  I think I just fixed the script `lint-yaml.sh` with commit `2fae698`.
   
   Right now `submarine-cloud-v2/test/e2e/` is failing, but it passes in my previous commit. Should I be concerned?
   
   Also, should I mark this PR as a draft before autoformat and the corresponding docs are added? `yamllint` doesn't support formatting, and right now I'm looking at `yq`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org