[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9571: [multi-stage] allow configurable timeout

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9571:
URL: https://github.com/apache/pinot/pull/9571#discussion_r993831760


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -87,10 +88,18 @@ public MultiStageBrokerRequestHandler(PinotConfiguration config, BrokerRoutingMa
     }
     _reducerHostname = reducerHostname;
     _reducerPort = config.getProperty(QueryConfig.KEY_OF_QUERY_RUNNER_PORT, QueryConfig.DEFAULT_QUERY_RUNNER_PORT);
+    long brokerTimeoutMs = config.getProperty(CommonConstants.Broker.CONFIG_OF_BROKER_TIMEOUT_MS, -1L);
+    if (brokerTimeoutMs == -1) {
+      _timeoutNs = config.getProperty(QueryConfig.KEY_OF_QUERY_RUNNER_TIMEOUT_NANO,
+          QueryConfig.DEFAULT_QUERY_RUNNER_TIMEOUT_NANO);
+    } else {
+      _timeoutNs = brokerTimeoutMs * 1_000_000L;

Review Comment:
   So in the current engine, I think we use milliseconds and that is what (remaining) is passed to server as well. Do we want to keep this consistent especially because leaf layer execution is common and that code uses milliseconds for timeOut ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org