You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2010/12/01 19:34:11 UTC

[jira] Resolved: (MYFACES-2986) Provide an interface to override how to find spi interfaces

     [ https://issues.apache.org/jira/browse/MYFACES-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-2986.
-------------------------------------

    Resolution: Fixed

1) Ok, I committed the necessary changes.

2) Unfortunately in this point we only have an ExternalContext instance, so we can't check for project stage. I added a descriptive warning message indicating what's happening and the action taken. I think is the best we can do. Anyway, I already restored the code to override a Factory (allow AnnotationProviderFactory.setAnnotationProviderFactory ) so in the worst case users could create a custom initializer and call this method if something is not well configured.

> Provide an interface to override how to find spi interfaces
> -----------------------------------------------------------
>
>                 Key: MYFACES-2986
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2986
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>    Affects Versions: 2.0.2
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.3-SNAPSHOT
>
>         Attachments: MYFACES-2986-2.patch
>
>
> This is the last step to solve MYFACES-2944 and MYFACES-2945 problem related to OSGi and SPI. Now it is possible to call 
> ServiceLoaderFinderFactory.setServiceLoaderFinder(ExternalContext ectx, ServiceLoaderFinder slp)
> or 
> ServiceLoaderFinderFactory.setServiceLoaderFinder(ServletContext ctx, ServiceLoaderFinder slp)
> Just before initialization to set a ServiceLoaderFinder that will be used later to locate SPI interfaces. In this way, it is possible to provide a code that looks SPI interfaces using OSGi bundles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.