You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:08:11 UTC

[GitHub] [tvm] TylerADavis opened a new pull request #7128: Add `is_floating_point` and `div_` PyTorch ops

TylerADavis opened a new pull request #7128:
URL: https://github.com/apache/tvm/pull/7128


   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   
   This PR adds support for the `is_floating_point` and `div_` PyTorch operations, and closes #6239 .
   
   This PR does not include a unit test for `div_` as there is currently no unit test for `div`, and they share an implementation. Additionally, while I wrote a unit test for `is_floating_point()` (see https://github.com/apache/tvm/compare/main...TylerADavis:tyler_add_ops_incl_tests?expand=1), it is not included in this PR as models consisting solely of `is_floating_point` are compiled to constant graphs with no inputs, and the current testing infrastructure assumes that all graphs have inputs. The unit test for `is_floating_point()` tests the operator with `torch.jit.script` and `torch.jit.trace` with inputs consisting of `int8, float64, float32`, and `float16`. Each of these test cases passes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7128: Add `is_floating_point` and `div_` PyTorch ops

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7128:
URL: https://github.com/apache/tvm/pull/7128#issuecomment-747928318


   Thanks @TylerADavis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7128: Add `is_floating_point` and `div_` PyTorch ops

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7128:
URL: https://github.com/apache/tvm/pull/7128#issuecomment-747862332


   Have you looked at `verify_script_model` in pytorch/test_forward.py? It might help for adding tests for `is_floating_point`.  I also encountered an empty graph when writing a test for `torch.numel` with tracing. See `test_numel()` for its usage. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] TylerADavis commented on pull request #7128: Add `is_floating_point` and `div_` PyTorch ops

Posted by GitBox <gi...@apache.org>.
TylerADavis commented on pull request #7128:
URL: https://github.com/apache/tvm/pull/7128#issuecomment-747854049


   Hi, I just ran `black` on `pytorch.py` and pushed the changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #7128: Add `is_floating_point` and `div_` PyTorch ops

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7128:
URL: https://github.com/apache/tvm/pull/7128


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7128: Add `is_floating_point` and `div_` PyTorch ops

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7128:
URL: https://github.com/apache/tvm/pull/7128#issuecomment-747848521


   Thanks, please run `black` to fix formatting.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org