You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-commits@incubator.apache.org by jw...@apache.org on 2007/01/31 02:59:12 UTC
svn commit: r501699 - in /incubator/adffaces/trunk/trinidad:
trinidad-api/pom.xml trinidad-impl/pom.xml
Author: jwaldman
Date: Tue Jan 30 18:59:12 2007
New Revision: 501699
URL: http://svn.apache.org/viewvc?view=rev&rev=501699
Log:
Added to the pom files so that the MANIFEST.MF will pick up the implementation-version String.
<configuration>
<archive>
<manifest>
<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration>
Modified:
incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml
incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml
Modified: incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml?view=diff&rev=501699&r1=501698&r2=501699
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml Tue Jan 30 18:59:12 2007
@@ -38,6 +38,14 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <archive>
+ <manifest>
+ <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+ <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+ </manifest>
+ </archive>
+ </configuration>
<executions>
<execution>
<goals>
Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml?view=diff&rev=501699&r1=501698&r2=501699
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml Tue Jan 30 18:59:12 2007
@@ -88,6 +88,14 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <archive>
+ <manifest>
+ <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+ <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+ </manifest>
+ </archive>
+ </configuration>
<executions>
<execution>
<goals>
Re: svn commit: r501699 - in /incubator/adffaces/trunk/trinidad:
trinidad-api/pom.xml trinidad-impl/pom.xml
Posted by Jeanne Waldman <je...@oracle.com>.
Folks,
Matthias and I are looking at this offline.
My faces-config.xml in $TRIN_HOME/trinidad-impl/target/classes/META-INF
is fine.
I even tested this jar and saw that my generated css file no longer has
unknown-version in it.
We are both on maven 2.0.4.
- Jeanne
Matthias Wessendorf wrote:
> Hey Jeanne,
>
> that fix is causing issues with the META-INF stuff in the jars
> (for instance an empty faces-config.xml inside the JAR, since there no
> one generated to
>
> $TRIN_HOME/trinidad-impl/target/classes/META-INF
>
> I did an "undo" for now,
>
> thx
>
> On 1/31/07, jwaldman@apache.org <jw...@apache.org> wrote:
>> Author: jwaldman
>> Date: Tue Jan 30 18:59:12 2007
>> New Revision: 501699
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=501699
>> Log:
>> Added to the pom files so that the MANIFEST.MF will pick up the
>> implementation-version String.
>> <configuration>
>> <archive>
>> <manifest>
>>
>> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
>>
>> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>> </manifest>
>> </archive>
>> </configuration>
>>
>> Modified:
>> incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml
>> incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml
>>
>> Modified: incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml?view=diff&rev=501699&r1=501698&r2=501699
>>
>> ==============================================================================
>>
>> --- incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml (original)
>> +++ incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml Tue Jan 30
>> 18:59:12 2007
>> @@ -38,6 +38,14 @@
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-jar-plugin</artifactId>
>> + <configuration>
>> + <archive>
>> + <manifest>
>> +
>> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
>> +
>> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>> + </manifest>
>> + </archive>
>> + </configuration>
>> <executions>
>> <execution>
>> <goals>
>>
>> Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml?view=diff&rev=501699&r1=501698&r2=501699
>>
>> ==============================================================================
>>
>> --- incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml (original)
>> +++ incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml Tue Jan
>> 30 18:59:12 2007
>> @@ -88,6 +88,14 @@
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-jar-plugin</artifactId>
>> + <configuration>
>> + <archive>
>> + <manifest>
>> +
>> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
>> +
>> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>> + </manifest>
>> + </archive>
>> + </configuration>
>> <executions>
>> <execution>
>> <goals>
>>
>>
>>
>
>
Re: svn commit: r501699 - in /incubator/adffaces/trunk/trinidad: trinidad-api/pom.xml trinidad-impl/pom.xml
Posted by Matthias Wessendorf <ma...@apache.org>.
Hey Jeanne,
that fix is causing issues with the META-INF stuff in the jars
(for instance an empty faces-config.xml inside the JAR, since there no
one generated to
$TRIN_HOME/trinidad-impl/target/classes/META-INF
I did an "undo" for now,
thx
On 1/31/07, jwaldman@apache.org <jw...@apache.org> wrote:
> Author: jwaldman
> Date: Tue Jan 30 18:59:12 2007
> New Revision: 501699
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=501699
> Log:
> Added to the pom files so that the MANIFEST.MF will pick up the implementation-version String.
> <configuration>
> <archive>
> <manifest>
> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> </manifest>
> </archive>
> </configuration>
>
> Modified:
> incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml
> incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml
>
> Modified: incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml?view=diff&rev=501699&r1=501698&r2=501699
> ==============================================================================
> --- incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml (original)
> +++ incubator/adffaces/trunk/trinidad/trinidad-api/pom.xml Tue Jan 30 18:59:12 2007
> @@ -38,6 +38,14 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> + <configuration>
> + <archive>
> + <manifest>
> + <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> + <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> + </manifest>
> + </archive>
> + </configuration>
> <executions>
> <execution>
> <goals>
>
> Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml?view=diff&rev=501699&r1=501698&r2=501699
> ==============================================================================
> --- incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml (original)
> +++ incubator/adffaces/trunk/trinidad/trinidad-impl/pom.xml Tue Jan 30 18:59:12 2007
> @@ -88,6 +88,14 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> + <configuration>
> + <archive>
> + <manifest>
> + <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> + <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> + </manifest>
> + </archive>
> + </configuration>
> <executions>
> <execution>
> <goals>
>
>
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com