You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/30 16:25:41 UTC

[GitHub] [tvm] mbrookhart opened a new pull request #7956: [ONNX] More Unit Tests!

mbrookhart opened a new pull request #7956:
URL: https://github.com/apache/tvm/pull/7956


   @jwfromm Fixes a few straggling onnx unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on a change in pull request #7956: [ONNX] More Unit Tests!

Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #7956:
URL: https://github.com/apache/tvm/pull/7956#discussion_r624161806



##########
File path: src/relay/op/tensor/transform.cc
##########
@@ -1120,6 +1120,8 @@ bool ScatterNDRel(const Array<Type>& types, int num_inputs, const Attrs& attrs,
 
   const auto out_shape = data->shape;
   const IntImmNode* mdim = indices->shape[0].as<IntImmNode>();
+  ICHECK(mdim) << "GatherND needs a static shape for the first axis of indices, got "

Review comment:
       ScatterND




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi merged pull request #7956: [ONNX] More Unit Tests!

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7956:
URL: https://github.com/apache/tvm/pull/7956


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #7956: [ONNX] More Unit Tests!

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7956:
URL: https://github.com/apache/tvm/pull/7956#issuecomment-831007264


   Thanks @mbrookhart @jroesch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org