You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/08/03 17:12:15 UTC
Review Request 61409: GEODE-3328: simplify GfshParserRule
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/
-----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3328: simplify GfshParserRule
another step towards refactor connect command, some simple rule change.
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03
Diff: https://reviews.apache.org/r/61409/diff/1/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 61409: GEODE-3328: simplify GfshParserRule
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/#review182131
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61409/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 5:12 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3328: simplify GfshParserRule
>
> another step towards refactor connect command, some simple rule change.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03
>
>
> Diff: https://reviews.apache.org/r/61409/diff/1/
>
>
> Testing
> -------
>
> precheckin running, tests
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61409: GEODE-3328: simplify GfshParserRule
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/#review182225
-----------------------------------------------------------
Ship it!
I think this is a good improvement to the rule's API.
- Jared Stewart
On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61409/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 5:12 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3328: simplify GfshParserRule
>
> another step towards refactor connect command, some simple rule change.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03
>
>
> Diff: https://reviews.apache.org/r/61409/diff/1/
>
>
> Testing
> -------
>
> precheckin running, tests
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61409: GEODE-3328: simplify GfshParserRule
Posted by Emily Yeh <ey...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/#review182529
-----------------------------------------------------------
Ship it!
Ship It!
- Emily Yeh
On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61409/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 5:12 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3328: simplify GfshParserRule
>
> another step towards refactor connect command, some simple rule change.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03
>
>
> Diff: https://reviews.apache.org/r/61409/diff/1/
>
>
> Testing
> -------
>
> precheckin running, tests
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61409: GEODE-3328: simplify GfshParserRule
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/#review182227
-----------------------------------------------------------
Ship it!
Ship It!
- Ken Howe
On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61409/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 5:12 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3328: simplify GfshParserRule
>
> another step towards refactor connect command, some simple rule change.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03
>
>
> Diff: https://reviews.apache.org/r/61409/diff/1/
>
>
> Testing
> -------
>
> precheckin running, tests
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 61409: GEODE-3328: simplify GfshParserRule
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61409/
-----------------------------------------------------------
(Updated Aug. 3, 2017, 5:12 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3328: simplify GfshParserRule
another step towards refactor connect command, some simple rule change.
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java 0700742fac70730c160d28c62c93b824e8ee0a3c
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java 059611dc1c5101643cbae18d067a2943a573d405
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java c2810801257479ad9a31452f294daaaf2975dfad
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java b1bc7aa73b7d9273ad9a89af4c119d91a67aae03
Diff: https://reviews.apache.org/r/61409/diff/1/
Testing (updated)
-------
precheckin running, tests
Thanks,
Jinmei Liao