You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 21:27:00 UTC
[jira] [Commented] (METRON-1527) Remove dead test file sitting in
source folder
[ https://issues.apache.org/jira/browse/METRON-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440048#comment-16440048 ]
ASF GitHub Bot commented on METRON-1527:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/994
METRON-1527: Remove dead test file sitting in source folder
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1527
There was a nonsense test file left in metron-common src dir. Just removing that file - Travis already ran successfully on my private branch.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron remove-dead-file
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #994
----
commit 87451af9311b66f2c431be07fd3411efa2b915d4
Author: Michael Miklavcic <mi...@...>
Date: 2018-04-16T20:43:57Z
Remove dead test file sitting in source folder.
----
> Remove dead test file sitting in source folder
> ----------------------------------------------
>
> Key: METRON-1527
> URL: https://issues.apache.org/jira/browse/METRON-1527
> Project: Metron
> Issue Type: Task
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
> While working on modifying the KafkaWriter I found an errant file in the metron-common src directory
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)