[jira] Commented: (JCR-863) Patch to use FileLock for locking instead of empty file

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498460 ] 

Jukka Zitting commented on JCR-863:
-----------------------------------

Good point, and thanks for the patch! (And sorry for the delayed feedback...)

The patch looks good to me, though it might have the same issues as recently discussed in issues JCR-912 and JCR-933. Also, I guess the change of the DISABLE_LOCKS constant is an oversight. Could you check these issues?

You haven't marked the attachment with the "Grant license to ASF" option on the attachment upload screen. I guess that's also an oversight. You can fix that either by uploading a new version of the patch and selecting the option, or simply by commenting here that you grant us the right to use the code under the Apache License.

> Patch to use FileLock for locking instead of empty file
> -------------------------------------------------------
>
>                 Key: JCR-863
>                 URL: https://issues.apache.org/jira/browse/JCR-863
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>            Reporter: Michael Neale
>             Fix For: 1.4
>
>         Attachments: FSDirectory.patch
>
>
> The FSDirectory uses File.createNewFile to effectively lock a directory (in makeLock), yet the Java Spec says explcitly not to use it for this purpose, and instead use FileLock from nio.
> The attached patch shows how this is/could be done (change is internal to the makeLock method only, and functionally equivalent, the same tests apply).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.