You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/05 14:16:25 UTC
[GitHub] [netbeans] oyarzun opened a new pull request #1999: [NETBEANS-3332]
get latest archetype from maven repo
oyarzun opened a new pull request #1999: [NETBEANS-3332] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999
Query the maven repository to get the latest version of nbm-archetype and netbeans-platform-app-archetype. If this fails for some reason it will use the hard coded version.
- nbm-archetype: 1.18 apache/netbeans-mavenutils-archetype-nbm-archetype#1
- netbeans-platform-app-archetype: 1.23 /apache/netbeans-mavenutils-archetype-netbeans-platform-app-archetype#2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #1999: [NETBEANSINFRA-6]
get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1999: [NETBEANSINFRA-6] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #1999:
[NETBEANS-3332] get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #1999: [NETBEANS-3332] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#discussion_r388932972
##########
File path: apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java
##########
@@ -62,12 +64,12 @@
static {
NB_MODULE_ARCH = new Archetype();
NB_MODULE_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_MODULE_ARCH.setVersion("1.17"); //NOI18N
+ NB_MODULE_ARCH.setVersion("1.18"); //NOI18N
NB_MODULE_ARCH.setArtifactId("nbm-archetype"); //NOI18N
NB_APP_ARCH = new Archetype();
NB_APP_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_APP_ARCH.setVersion("1.22"); //NOI18N
+ NB_APP_ARCH.setVersion("1.23"); //NOI18N
NB_APP_ARCH.setArtifactId("netbeans-platform-app-archetype"); //NOI18N
Review comment:
Reverting the version is just to make this PR works, archetype need to be released via voting first.
Making possible to test without needing archetype.
in short this PR is for get latest archetype.
Once merged will be a second PR only with version changes that can wait for release.
2 steps fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1999:
[NETBEANSINFRA-6] get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1999: [NETBEANSINFRA-6] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#issuecomment-596251422
This was squashed and merged on github - the author name is not recorded correctly in the resulting commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on a change in pull request #1999:
[NETBEANS-3332] get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
oyarzun commented on a change in pull request #1999: [NETBEANS-3332] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#discussion_r388929333
##########
File path: apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java
##########
@@ -62,12 +64,12 @@
static {
NB_MODULE_ARCH = new Archetype();
NB_MODULE_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_MODULE_ARCH.setVersion("1.17"); //NOI18N
+ NB_MODULE_ARCH.setVersion("1.18"); //NOI18N
NB_MODULE_ARCH.setArtifactId("nbm-archetype"); //NOI18N
NB_APP_ARCH = new Archetype();
NB_APP_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_APP_ARCH.setVersion("1.22"); //NOI18N
+ NB_APP_ARCH.setVersion("1.23"); //NOI18N
NB_APP_ARCH.setArtifactId("netbeans-platform-app-archetype"); //NOI18N
Review comment:
@ebarboni I saw that you merged apache/netbeans-mavenutils-archetype-nbm-archetype#1 and apache/netbeans-mavenutils-archetype-netbeans-platform-app-archetype#2 as part of the fix for [NETBEANSINFRA-6][1].
So you would like me to revert the archetype version numbers in the diff you mention in your previous comment?
My thought was that if for some reason the code to query the maven repo for the latest versions did not return the latest value then it would use the defaults which has the fix for [NETBEANSINFRA-6][1]. Although if querying the repo fails then the user probably has other problems.
[1]: https://issues.apache.org/jira/browse/NETBEANSINFRA-6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #1999:
[NETBEANS-3332] get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #1999: [NETBEANS-3332] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#discussion_r388932972
##########
File path: apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java
##########
@@ -62,12 +64,12 @@
static {
NB_MODULE_ARCH = new Archetype();
NB_MODULE_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_MODULE_ARCH.setVersion("1.17"); //NOI18N
+ NB_MODULE_ARCH.setVersion("1.18"); //NOI18N
NB_MODULE_ARCH.setArtifactId("nbm-archetype"); //NOI18N
NB_APP_ARCH = new Archetype();
NB_APP_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_APP_ARCH.setVersion("1.22"); //NOI18N
+ NB_APP_ARCH.setVersion("1.23"); //NOI18N
NB_APP_ARCH.setArtifactId("netbeans-platform-app-archetype"); //NOI18N
Review comment:
Reverting the version is just to make this PR works, archetype need to be released via voting first.
Making possible to test without needing archetype.
in short this PR is for get latest archetype.
Once merged will be a second PR only with version changes that can wait for release.
2 steps fix
Because getting last version may be a common pattern for other module too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #1999:
[NETBEANS-3332] get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #1999: [NETBEANS-3332] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#discussion_r388932972
##########
File path: apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java
##########
@@ -62,12 +64,12 @@
static {
NB_MODULE_ARCH = new Archetype();
NB_MODULE_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_MODULE_ARCH.setVersion("1.17"); //NOI18N
+ NB_MODULE_ARCH.setVersion("1.18"); //NOI18N
NB_MODULE_ARCH.setArtifactId("nbm-archetype"); //NOI18N
NB_APP_ARCH = new Archetype();
NB_APP_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_APP_ARCH.setVersion("1.22"); //NOI18N
+ NB_APP_ARCH.setVersion("1.23"); //NOI18N
NB_APP_ARCH.setArtifactId("netbeans-platform-app-archetype"); //NOI18N
Review comment:
Reverting the version is just to make this PR works, archetype need to be released via voting first.
Making possible to test without needing archetype.
in short this PR is for get latest archetype.
Once merged will be a second PR only with version changes that can wait for release.
2 steps fix
--
Because getting last version may be a common pattern for other module too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1999: [NETBEANSINFRA-6] get
latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1999: [NETBEANSINFRA-6] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#issuecomment-596087204
thnks merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #1999:
[NETBEANS-3332] get latest archetype from maven repo
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #1999: [NETBEANS-3332] get latest archetype from maven repo
URL: https://github.com/apache/netbeans/pull/1999#discussion_r388466270
##########
File path: apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java
##########
@@ -62,12 +64,12 @@
static {
NB_MODULE_ARCH = new Archetype();
NB_MODULE_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_MODULE_ARCH.setVersion("1.17"); //NOI18N
+ NB_MODULE_ARCH.setVersion("1.18"); //NOI18N
NB_MODULE_ARCH.setArtifactId("nbm-archetype"); //NOI18N
NB_APP_ARCH = new Archetype();
NB_APP_ARCH.setGroupId("org.apache.netbeans.archetypes"); //NOI18N
- NB_APP_ARCH.setVersion("1.22"); //NOI18N
+ NB_APP_ARCH.setVersion("1.23"); //NOI18N
NB_APP_ARCH.setArtifactId("netbeans-platform-app-archetype"); //NOI18N
Review comment:
First @oyarzun I'm sorry the related issue is to another JIRA now. NETBEANSINFRA-6
Maybe revert the version to released. So we can integrate your changes not hurting.
I'll try to get the plugins archetype with your modification merge done asap and we can see if new version are found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists