[jira] Commented: (WAGON-73) MirroredWagon infinite loop

["Phil Webb (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/WAGON-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_96821 ] 

Phil Webb commented on WAGON-73:
--------------------------------

Are you sure that this is fixed on the trunk?  I believe that the maven eclipse project was tested with the patch applied.  The SVN code does not appear to have the patch.  

Looking at the code I cannot see how the loop in the connect method will return when the connection is successful (ie when there are no exceptions).


> MirroredWagon infinite loop
> ---------------------------
>
>                 Key: WAGON-73
>                 URL: http://jira.codehaus.org/browse/WAGON-73
>             Project: wagon
>          Issue Type: Bug
>            Reporter: Phillip Webb
>            Assignee: Joakim Erdfelt
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: returnsonmirroredwagon.patch
>
>
> The MirroredWagon class includes a get method that runs into an infinite loop.
> I think a return is required after this.impl.get( resource, destination );
>     public void get( String resource, File destination )
>         throws TransferFailedException, ResourceDoesNotExistException, AuthorizationException
>     {
>         try
>         {
>             while ( true )
>             {
>                 try
>                 {
>                     this.impl.get( resource, destination );
>                 }
>                 catch ( TransferFailedException e )
>                 {
>                     nextMirror();
>                 }
>             }
>         }
>         catch ( ExhaustedMirrorsException e )
>         {
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira