You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zoltan Haindrich <ki...@rxd.hu> on 2018/08/01 18:29:05 UTC
Re: Review Request 68108: HIVE-19097 related equals and in operators
may cause inaccurate stats estimations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68108/#review206737
-----------------------------------------------------------
ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/68108/#comment289830>
These cases are not handled...because there are columns on both sides.
- Zoltan Haindrich
On July 30, 2018, 4:13 p.m., Zoltan Haindrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68108/
> -----------------------------------------------------------
>
> (Updated July 30, 2018, 4:13 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Gopal V.
>
>
> Bugs: HIVE-19097
> https://issues.apache.org/jira/browse/HIVE-19097
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> * open in to or
> * close ors into in at 2
> * wip patch
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 39c77b3fe52cb7d7d255138bb71d77a170347b52
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java f544f586321c2496e9f3bc3b428ae5689bf046a9
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java b57b5ddc2cba688897bac4cf29eaf9679b6de375
> ql/src/test/results/clientpositive/alter_partition_coltype.q.out 5d033a3c0181d697f08ac1aeb62ef57071602050
> ql/src/test/results/clientpositive/annotate_stats_filter.q.out 54395886d2a58d83b0fd853c0008fc99f7063f0c
> ql/src/test/results/clientpositive/annotate_stats_part.q.out 29ef214ff0e8678fe25bd1793a9522ea0ae61d32
> ql/src/test/results/clientpositive/auto_join19.q.out 3e07ec06de767099aeb14beea586bca4cca0784e
> ql/src/test/results/clientpositive/cbo_rp_simple_select.q.out d12b5f64cc70e0039ce9179c5c6fb90d8beba0d1
> ql/src/test/results/clientpositive/cbo_simple_select.q.out 588d924e6af9b704577b9acf9a01d139c1b13af7
> ql/src/test/results/clientpositive/druid_basic3.q.out 54719f751769722c6b099682b9742b1e21c6ebec
> ql/src/test/results/clientpositive/druid_intervals.q.out a5203c31822ef6cb8c70a0caa9b682b6f73e88f5
> ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out 97922c2636f5b7bc101505bd9fd69b8f24719003
> ql/src/test/results/clientpositive/filter_cond_pushdown.q.out b84a2d4b796acc0cc80eef48ddecb97aeb96f7c5
> ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out d06fb603458941dd7f79485c6cd8b3a105995c54
> ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out 6217adb5d4a1c04506d8020a9c9d4b7932c637a3
> ql/src/test/results/clientpositive/llap/bucketpruning1.q.out cc637db05bbbb0d5ec915220865c654e7596a8fe
> ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out c7f5b887b6396cf60b02b70e87371a21a0052b57
> ql/src/test/results/clientpositive/llap/cbo_simple_select.q.out a35edb42a851d5c6ca6ff7fb21a8172788c34d55
> ql/src/test/results/clientpositive/llap/check_constraint.q.out 123a3e46fccefba6ee12b98424b785c0eaef4eed
> ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out 8f06ee58ceed021a254491f62069e1b8e18c1541
> ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out e03cd3437e34179d0557ff1de63ca31cd7f1e3fe
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out 708fa176170bb615d1032c810a8332fb64c9a23d
> ql/src/test/results/clientpositive/llap/kryo.q.out 234bae89c7a25da3b0db2efa397444dd6c5872c4
> ql/src/test/results/clientpositive/llap/llap_decimal64_reader.q.out 88ddd9c0767b6c23f423ab1ad7e350eba7f85d1a
> ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb.q.out 1841f1f4d3222314374d155fe5f7484a7e4628f2
> ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb_2.q.out d7c92d8c59e26a899129f1f816fc79d9a67b5c6b
> ql/src/test/results/clientpositive/llap/vector_between_in.q.out 12ae1032eabb51a6c9c9f1a7204483128eb2848d
> ql/src/test/results/clientpositive/llap/vector_string_decimal.q.out 54d9914caa6f1cfc569ee8237e83bfc345382e66
> ql/src/test/results/clientpositive/llap/vector_windowing_multipartitioning.q.out 725ed34acb6b9e1e5e074a31571a202720480aaa
> ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 74ac56d1c6989e33f48f82a25742c1c020a9494b
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out d444ae86a10ec96a999895b118aab3fa7ac9c653
> ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out ba004e97168807da0718c75d371dcdfdc741dca1
> ql/src/test/results/clientpositive/pcr.q.out 919b71234d56a63789c33470022bbf637b054444
> ql/src/test/results/clientpositive/perf/spark/query13.q.out fb2a061c635f22594bfeb1baa5e8af61bb6b80fe
> ql/src/test/results/clientpositive/perf/spark/query15.q.out 3d6fbdac777e68b65ddd1d21f888f8f53ab4b704
> ql/src/test/results/clientpositive/perf/spark/query34.q.out b40081e4f07b0a0cfb10157ae917c233e1295de9
> ql/src/test/results/clientpositive/perf/spark/query45.q.out d61f8b80521748965ba8b19992013ef028599c50
> ql/src/test/results/clientpositive/perf/spark/query48.q.out 60a4767a14575b2c3adf998a561c5a459eb2d2dc
> ql/src/test/results/clientpositive/perf/spark/query53.q.out 2b1cdfea988efd767f18b8ff92792c0e97fde280
> ql/src/test/results/clientpositive/perf/spark/query63.q.out b506455dbfd317a8cc9d64fd211a4e366993aa79
> ql/src/test/results/clientpositive/perf/spark/query71.q.out bf9c06debf98463c8554e4ea2f00a94bb5f4def1
> ql/src/test/results/clientpositive/perf/spark/query73.q.out 20ec874e88dd07785fee487892c1338ce5c85596
> ql/src/test/results/clientpositive/perf/spark/query8.q.out 6b14eb9bb007d4ebfaaddbd8ac7138fce1ca5e5b
> ql/src/test/results/clientpositive/perf/spark/query85.q.out 572ba54f7873e7759c56f1830ea583044cf68e9a
> ql/src/test/results/clientpositive/perf/spark/query89.q.out 1acc57766979ffbd1eb916f1a5e8cfff695bce69
> ql/src/test/results/clientpositive/perf/spark/query91.q.out de8977da51e6976efe61caecc05ec60ea5e2d328
> ql/src/test/results/clientpositive/perf/tez/query13.q.out 5cd4e27de3e1faa13cc2a5767ec43ad7347eb24c
> ql/src/test/results/clientpositive/perf/tez/query15.q.out 3c7ae664b10bdc23903f8a6b9152e40c9eab2aa2
> ql/src/test/results/clientpositive/perf/tez/query34.q.out 9b7b482d3b795add63b11e0641550e913e4b6b02
> ql/src/test/results/clientpositive/perf/tez/query45.q.out edb047d3f56017a52efafda67095504aadd7fe83
> ql/src/test/results/clientpositive/perf/tez/query48.q.out 1cf8d5c0dab253ce2494e1d94d78a6448183c9c2
> ql/src/test/results/clientpositive/perf/tez/query53.q.out 3567534ac4c8f161b1902605e96eacab996e9b7c
> ql/src/test/results/clientpositive/perf/tez/query63.q.out a5b7b5a788db466def6df144de99dea33c40fcfc
> ql/src/test/results/clientpositive/perf/tez/query71.q.out 4521aabc9f176abd89c989ecc1a8d2d511c74f31
> ql/src/test/results/clientpositive/perf/tez/query73.q.out cfa5213b5e237ce35d4cae1f45a235fca2a3c917
> ql/src/test/results/clientpositive/perf/tez/query8.q.out ee20e61ff4f0ad3cb226cca4ea36dd8dc976ec64
> ql/src/test/results/clientpositive/perf/tez/query85.q.out 4e42d697357e27eb9b2774d97ba3bd07f5331711
> ql/src/test/results/clientpositive/perf/tez/query89.q.out ee3374ea5ce2a3b1a6dc947d946df73782645380
> ql/src/test/results/clientpositive/pointlookup.q.out 69ae098a418e09d70f0dd562c11a2dc86f95e2d6
> ql/src/test/results/clientpositive/pointlookup2.q.out 1eba541ff0eaa2c11edd34fcd117f0bbd8046f0c
> ql/src/test/results/clientpositive/pointlookup3.q.out 8835d4188c9abdf3d7439a9550d15f2107a2ee8f
> ql/src/test/results/clientpositive/ppd_transform.q.out b38088f16a90393adf1939a0174ee20686b13fb3
> ql/src/test/results/clientpositive/remove_exprs_stats.q.out a9c0051371db45a668fad536d206535fe6843799
> ql/src/test/results/clientpositive/spark/auto_join19.q.out d7d8caee33bd51a315c64f038262cd47570b4bbd
> ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out e07904ac445ad32559b254ff0777c19b4e861419
> ql/src/test/results/clientpositive/spark/cbo_simple_select.q.out a35edb42a851d5c6ca6ff7fb21a8172788c34d55
> ql/src/test/results/clientpositive/spark/pcr.q.out 83437e55936e05f7a5f6f2a116e4bbe980c9768e
> ql/src/test/results/clientpositive/spark/ppd_transform.q.out 4dfc0fed6e292169c92560f71302944eef209cc0
> ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out 24202522f584ad1308edcac626627421a102406d
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out c5d0d63f8c80a5b1c0e57cf0c0595b7229d8e315
> ql/src/test/results/clientpositive/spark/vector_between_in.q.out 78bcd26f561eb2449ec7a45f99156f04794aed2f
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 0bf2a4bfa53b732777ee6d074146693df5ee5954
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 669adafda3a45f7846face3d99817cd1b9cb3664
> ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out 5a50431d267bb595a6c88c87bd2f8aed26ac92f7
> ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out 966edad0258f7e80a27163a46f7a4e7071efe893
> ql/src/test/results/clientpositive/vectorized_case.q.out 828131f8c616cb74cca2fb20de3dd4b9190c0718
>
>
> Diff: https://reviews.apache.org/r/68108/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zoltan Haindrich
>
>