You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/02/08 12:10:00 UTC
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message
routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356859#comment-16356859 ]
ASF subversion and git services commented on ARTEMIS-1633:
----------------------------------------------------------
Commit 33b265ca6bf5b84553500dddcf096b13683bb8c8 in activemq-artemis's branch refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=33b265c ]
ARTEMIS-1633 - Include populated RoutingContext in beforeMessageRoute
call
There was a small bug in the previous commit, the beforeMessageRoute
callback was being executed too early so the RoutingCountext wasn't
being filled in
> ActiveMQServerPlugin message routing callbacks should fire for all results
> --------------------------------------------------------------------------
>
> Key: ARTEMIS-1633
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1633
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.5.0
>
>
> When I added the callbacks for beforeMessageRoute and afterMessageRoute I accidentally inserted them so that they will only be called when the RoutingStatus result is OK. They should always be called even if the status is no bindings, or no bindings DLA, etc to allow the plugin writer to handle events depending on the routing status.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)