You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2010/03/31 13:05:26 UTC

Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

On 31/03/2010, henrib@apache.org <he...@apache.org> wrote:
> Author: henrib
>  Date: Wed Mar 31 08:53:56 2010
>  New Revision: 929437
>
>  URL: http://svn.apache.org/viewvc?rev=929437&view=rev
>  Log:
>  Prepare for 2.0.1 RC2:
>  - Updated findbugs spec to exclude generated sources

That was not all that was changed ...

>  Added:
>     commons/proper/jexl/trunk/src/main/config/findbugs-exclude-filter.xml   (with props)
>  Modified:
>     commons/proper/jexl/trunk/pom.xml
>
>  Modified: commons/proper/jexl/trunk/pom.xml
>  URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/pom.xml?rev=929437&r1=929436&r2=929437&view=diff
>  ==============================================================================
>  --- commons/proper/jexl/trunk/pom.xml (original)
>  +++ commons/proper/jexl/trunk/pom.xml Wed Mar 31 08:53:56 2010
>  @@ -117,7 +117,7 @@
>          <commons.componentid>jexl</commons.componentid>
>          <commons.release.version>2.0.1</commons.release.version>
>          <!-- The RC version used in the staging repository URL. -->
>  -        <commons.rc.version>RC1</commons.rc.version>
>  +        <commons.rc.version>RC2</commons.rc.version>
>          <commons.release.2.version>1.1</commons.release.2.version>
>          <commons.release.2.binary.suffix />
>          <commons.jira.id>JEXL</commons.jira.id>
>  @@ -257,10 +257,7 @@
>                  <artifactId>findbugs-maven-plugin</artifactId>
>                  <version>2.3.1</version>
>                  <configuration>
>  -                        <excludes>
>  -                            <exclude>org/apache/commons/jexl2/parser/*.class</exclude>
>  -                            <exclude>org/apache/commons/jexl2/**/*Test.class</exclude>
>  -                        </excludes>
>  +                   <excludeFilterFile>${basedir}/src/main/config/findbugs-exclude-filter.xml</excludeFilterFile>
>                      <xmlOutput>true</xmlOutput>
>                      <!-- Optional directory to put findbugs xdoc xml report -->
>                      <xmlOutputDirectory>target/site</xmlOutputDirectory>
>  @@ -273,8 +270,7 @@
>                  <configuration>
>                      <targetJdk>1.5</targetJdk>
>                      <excludes>
>  -                        <exclude>org/apache/commons/jexl2/parser/*.class</exclude>
>  -                        <exclude>org/apache/commons/jexl2/**/*Test.class</exclude>
>  +                        <excludes>**/generated-sources/**/*</excludes>
>                      </excludes>
>                      <rulesets>
>                          <ruleset>/rulesets/braces.xml</ruleset>
>  @@ -327,6 +323,17 @@
>                  </site>
>              </distributionManagement>
>          </profile>
>  +        <profile>
>  +            <id>henrib</id>

Surely the rc profile in commons parent does the same?

>  +            <distributionManagement>
>  +                <!-- RC site deployment profile -->
>  +                <site>
>  +                    <id>apache.website</id>
>  +                    <name>Apache Commons Release Candidate Staging Site</name>
>  +                    <url>${commons.deployment.protocol}://people.apache.org/home/henrib/public_html/${commons.componentid}-${commons.release.version}-${commons.rc.version}/site</url>
>  +                </site>
>  +            </distributionManagement>
>  +        </profile>
>      </profiles>
>
>   </project>
>  \ No newline at end of file
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by henrib <he...@apache.org>.
Ooops, too late, RC3 out... 
With a bit of luck, I'll get your +1 vote. :-)
-- 
View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1747181.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by sebb <se...@gmail.com>.
On 31/03/2010, henrib <he...@apache.org> wrote:
>
>
>  Or I can just do 'zip -r site site' and upload like the artefacts...
>  Guess I'll have to update the pom (just the pom, nothing else) and try a
>  manual RC3 upload.
>  Third is a charm...

I would wait a bit and see what others say first - no point in redoing
the RC if there are other problems.

>
>
>  --
>  View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1747110.html
>
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by henrib <he...@apache.org>.

Or I can just do 'zip -r site site' and upload like the artefacts...
Guess I'll have to update the pom (just the pom, nothing else) and try a
manual RC3 upload.
Third is a charm...


-- 
View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1747110.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by sebb <se...@gmail.com>.
On 31/03/2010, henrib <he...@apache.org> wrote:
>
>
>  >> I still think the profile does not belong in the project pom.
>  >> Just add it to your settings.xml instead.
>
>
> I cant define the <distributionManagement .../> in my settings. How/where
>  can I put the staging site dir so it persists ?

You can provide it on the command-line:

http://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html#altDeploymentRepository

using -DaltDeploymentRepository

Might be able to define this in settings.xml as well.

Alternatively, you could perhaps create a profile.xml which is not in SVN?

>  >> s/inane/innate/ ?
>
>  I meant 'innane' (as in Lacking sense or meaning - often implying, "to the
>  point of boredom or annoyance" :-) ). I just wish I g{e,o}t faster to the
>  point where you would not have to catch all these inept errors I'm making.
>  Thanks again.
>
>
>  --
>  View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1746874.html
>
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by henrib <he...@apache.org>.

>> I still think the profile does not belong in the project pom. 
>> Just add it to your settings.xml instead. 

I cant define the <distributionManagement .../> in my settings. How/where
can I put the staging site dir so it persists ?

>> s/inane/innate/ ? 

I meant 'innane' (as in Lacking sense or meaning - often implying, "to the
point of boredom or annoyance" :-) ). I just wish I g{e,o}t faster to the
point where you would not have to catch all these inept errors I'm making.
Thanks again.

-- 
View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1746874.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by sebb <se...@gmail.com>.
On 31/03/2010, henrib <he...@apache.org> wrote:
>
>  Should have documented this, my bad.
>
>  I've added the 'henrib' profile to upload the RC site through 'mvn -Phenrib
>  site:deploy' in my home directory as http://...henrib/jexl-2.0.1-RC2/site.
>  The 'rc' profile would do so in the
>  http://.../builds/commons/jexl/2.0.1/RC2/site.

Ah - I'd not read the URL carefully enough.

I still think the profile does not belong in the project pom.

Just add it to your settings.xml instead.

>  Since most projects are staged in the home dir, I just tried to do the same
>  in a reproducible manner ( especially given my inane ability to screw-up the
>  release process ).

OK.

s/inane/innate/ ?

>
>  --
>  View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1746604.html
>  Sent from the Commons - Dev mailing list archive at Nabble.com.
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r929437 - in /commons/proper/jexl/trunk: pom.xml src/main/config/findbugs-exclude-filter.xml

Posted by henrib <he...@apache.org>.
Should have documented this, my bad.

I've added the 'henrib' profile to upload the RC site through 'mvn -Phenrib
site:deploy' in my home directory as http://...henrib/jexl-2.0.1-RC2/site.
The 'rc' profile would do so in the
http://.../builds/commons/jexl/2.0.1/RC2/site.

Since most projects are staged in the home dir, I just tried to do the same
in a reproducible manner ( especially given my inane ability to screw-up the
release process ). 

-- 
View this message in context: http://n4.nabble.com/Re-svn-commit-r929437-in-commons-proper-jexl-trunk-pom-xml-src-main-config-findbugs-exclude-filter-xl-tp1746587p1746604.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org