You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/11/12 19:58:48 UTC
Review Request 27902: Store host attributes alongside offers to reduce
number of lookups.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913
Repository: aurora
Description
-------
The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
Diff: https://reviews.apache.org/r/27902/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 12, 2014, 7:32 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 55
> > <https://reviews.apache.org/r/27902/diff/1/?file=759148#file759148line55>
> >
> > What does this mean exactly?
Typo, first one should read `IHostStatus`. I'll fix async, please don't allow this to prevent the rest of your review.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61035
-----------------------------------------------------------
On Nov. 12, 2014, 6:58 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61035
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java
<https://reviews.apache.org/r/27902/#comment102498>
What does this mean exactly?
- Zameer Manji
On Nov. 12, 2014, 10:58 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 10:58 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 10:38 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Fixed TODO, javadoc.
Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913
Repository: aurora
Description
-------
The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
Diff: https://reviews.apache.org/r/27902/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61031
-----------------------------------------------------------
Master (148f427) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/aurora/config/test_thrift.py::test_metadata_in_config PASSED
src/test/python/apache/aurora/config/test_thrift.py::test_task_instance_from_job PASSED
src/test/python/apache/aurora/config/test_thrift.py::test_identifier_validation PASSED
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.config.test_thrift.xml
========================== 10 passed in 1.49 seconds ===========================
Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)])
Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
rora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
BUILD, base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(B
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, updater)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, job_monitor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, quota_check)), PythonLibr
ary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD, util)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD, admin_util)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/BUILD, binding_helper)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, binding_helper)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/config/BUILD, config)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/config/schema/BUILD, schema)), PythonLibrary(BuildFileAddress(/home/jenkins/jen
kins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/BUILD, schema)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/BUILD, planner)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/BUILD, config)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, config)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, api)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, disambiguator)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, disambiguator)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/a
pache/aurora/client/api/BUILD, instance_watcher)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, job_monitor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/BUILD, fake_scheduler_proxy)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, mux)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, quota_check)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, restarter)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/auro
ra/client/api/BUILD, sla)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, updater)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/BUILD, updater_util)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, api)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, util)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/BUILD, cli)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD, command_runner)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/config/BUILD, schema)), PythonLibrary
(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/hooks/BUILD, hooks)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, factory)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD, options)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/BUILD, options)), PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/thermos/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/BUILD, client_lib)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/BUILD, bridge)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkin
s-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/bin/BUILD, aurora_admin_lib)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, admin)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, help)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, maintenance)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/bin/BUILD, aurora_client_lib)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, all)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, core)), PythonLibrary(BuildFileAddress(/home/jenkins/j
enkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, run)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/commands/BUILD, ssh)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, util)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, bridge)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, command_hooks)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, cron)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, help)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/t
est/python/apache/aurora/client/cli/BUILD, inspect)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, job)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, config)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, logging)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, plugins)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, quota)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, sla)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, task)), Pytho
nTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, supdate)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/BUILD, update)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, admin)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, core)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, hooks)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, maintenance)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, run)), PythonTests(BuildFileAddress(/hom
e/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/commands/BUILD, ssh)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/BUILD, hooked_api)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/BUILD, non_hooked_api)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_aurora_job_key)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_cluster)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_clusters)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_cluster_option)), PythonTests(BuildFileAddress(/home/jenkins/j
enkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_http_signaler)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_shellify)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/BUILD, test_transport)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/BUILD, test_base)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/BUILD, test_constraint_parsing)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/BUILD, test_loader)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/BUILD, test_thrift)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/
AuroraBot/src/test/python/apache/aurora/executor/BUILD, executor_base)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, executor_base)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/BUILD, executor_detector)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, executor_detector)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/BUILD, executor_vars)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, executor_vars)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/BUILD, status_manager)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/
AuroraBot/src/main/python/apache/aurora/executor/BUILD, status_manager)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, status_checker)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/BUILD, thermos_task_runner)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, sandbox)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, thermos_task_runner)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/BUILD, common)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/BUILD, ckpt)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/A
uroraBot/src/main/python/apache/thermos/common/BUILD, path)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/BUILD, core)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/BUILD, inspector)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/BUILD, muxer)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/BUILD, runner)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/BUILD, helper)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/BUILD, process)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/config/BUILD, config)), PythonLi
brary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, monitor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, task_info)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, task_runner)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, thermos_statuses)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/BUILD, announcer)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, announcer)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/BUILD, directory_s
andbox)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/BUILD, executor_timeout)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, executor_timeout)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/BUILD, health_checker)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/BUILD, fixtures)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/BUILD, health_checker)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/BUILD, status_checker)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/ap
ache/aurora/executor/common/BUILD, task_info)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/BUILD, gc_executor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, gc_executor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, detector)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, garbage)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/BUILD, thermos_executor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/BUILD, aurora_executor)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aur
ora/executor/common/BUILD, kill_manager)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/bin/BUILD, test_thermos)), PythonBinary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/bin/BUILD, thermos)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, monitoring)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, disk)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, process)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, resource)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/monitoring/BUILD, pro
cess_collector_psutil)), PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/testing/BUILD, runner)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/common/BUILD, test_pathspec)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/common/BUILD, test_planner)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/common/BUILD, test_task_planner)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/config/BUILD, test_schema)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_process)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_ephemerals)), Pytho
nTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_failing_runner)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_failure_limit)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_finalization)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_helper)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_runner_integration)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_angry)), PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/BUILD, test_staged_kill)), PythonTests(BuildFil
eAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/monitoring/BUILD, test_disk))]): Traceback (most recent call last):
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/commands/build.py", line 130, in _python_build
debug=self._verbose)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py", line 43, in build
debug=debug).run()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 88, in run
rv = self._run_tests([target], stdout, stderr)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 295, in _test_runner
builder = chroot.dump()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py", line 191, in dump
conn_timeout=self._conn_timeout)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py", line 100, in resolve_multi
platform=platform)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 101, in resolve
raise Unsatisfiable('Cannot satisfy requirements: %s' % requirement_set[requirement.key])
Unsatisfiable: Cannot satisfy requirements: [PythonRequirement(mesos.interface==0.20.1)]
Usage:
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exit Log an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fast Run tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 12, 2014, 6:58 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61124
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On Nov. 12, 2014, 10:38 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 10:38 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61139
-----------------------------------------------------------
Ship it!
Master (0077a0c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 12, 2014, 10:38 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 10:38 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 10:38 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913
Repository: aurora
Description
-------
The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
Diff: https://reviews.apache.org/r/27902/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 12, 2014, 9 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, line 97
> > <https://reviews.apache.org/r/27902/diff/1/?file=759147#file759147line97>
> >
> > s/org.apache.aurora.scheduler.//
Fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61065
-----------------------------------------------------------
On Nov. 12, 2014, 6:58 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61065
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java
<https://reviews.apache.org/r/27902/#comment102517>
s/org.apache.aurora.scheduler.//
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java
<https://reviews.apache.org/r/27902/#comment102518>
+1
- Maxim Khutornenko
On Nov. 12, 2014, 6:58 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27902: Store host attributes alongside offers to
reduce number of lookups.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61087
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Nov. 12, 2014, 10:58 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27902/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 10:58 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The big change here is to store `IHostAttributes` in `HostOffer` rather than `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the source code changes are trivial, but there was significant fallout in tests.
>
> Apologies again for the large diff. I could further break this up at API boundaries, but the review burden would be identical without reduced risk.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/TaskLauncher.java c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 250c2df8113adfd62b3a7e124f7994156c82b5f7
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 79d8d8d2e28665a6f2439d6242e58b9ce297875a
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java dd8a9005f1cdade662b418b197d5dfe480c65fa6
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java a17738e9b7f718184d8b46ff90a5c6d50d26aad6
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java d15d9e6b626b4cffd905b53deb1f3007bb7880bb
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b23457e0e64b490297166131a1b1b51b6d330415
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java fc17cac1088f9f9744126923c26862f6e4d7b4e0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c37272c9f46c086cb57b79a5202b3bd80e156f07
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 0533baa5e90ca62b8d35ba05474eaa8e27741a5a
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 446dc74e1f7f053299747d149ed181a93634eae8
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf
> src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 077699ff400ebe36eae5e608220ab83e0171c4db
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 9c9b659f9d4be0768489c4e4e124050ccb665d05
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 844a38a285f7abf917a844a7f6a4a14749aa9b57
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 083a63543e5f9041f13fc6be66877f7173a5bf32
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 758a8d419b45d9d890e714fd24020d2bbfa98c3f
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java e2a198add4da03ea0d8daf4f9614193f5fb04d6e
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java c0fa462c0ebe0b06fa354f5f63d5965827c669a1
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 0e699c99314782dcb511bd33dfb5ca50fb3dac75
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 0318179cd70661890f5a53908d1985d54474d476
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java bffbf83653535ecd9bf7b149e1e564c5fba56d17
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 052562fdb63e62b0cfbd6709ba67331f2592250c
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 563c1be4a89c2d057d1841690f6351322833c690
>
> Diff: https://reviews.apache.org/r/27902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>