You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/04/04 02:28:49 UTC

[GitHub] [yunikorn-scheduler-interface] wilfred-s commented on pull request #90: [YUNIKORN-1656] Extend si.EventRecord type

wilfred-s commented on PR #90:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/90#issuecomment-1495252317

   > Can we leave the existing IDs as-is and add the new ones to the end? If we are removing an ID, we should mark it reserved and skip it to maintain minimal backwards compatibility.
   
   We should do the same for Reason too. Keeps it clean: `reason` and `groupID` name and number should be marked as reserved (see this [comment](https://github.com/apache/yunikorn-scheduler-interface/pull/70/files#r939745366) for a reference


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org