You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/24 22:15:26 UTC
[GitHub] [cordova-plugin-device] janpio edited a comment on issue #99: Add
support for electron platform
janpio edited a comment on issue #99: Add support for electron platform
URL: https://github.com/apache/cordova-plugin-device/issues/99#issuecomment-495801962
That would mean that looking for ` Electron/` in the UA string could be a solution. Could be implemented quite cleanly in https://github.com/apache/cordova-plugin-device/blob/db0ad32f2a84db7cb4dd31887417fff0a59eac2f/src/browser/DeviceProxy.js#L23-L25
We did similar things in the past for other platforms:
https://github.com/apache/cordova-plugin-device/blob/db0ad32f2a84db7cb4dd31887417fff0a59eac2f/src/android/Device.java#L96-L104
Do you want to open a PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org