You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by "Sebb (Jira)" <ji...@apache.org> on 2020/09/25 23:36:00 UTC
[jira] [Resolved] (WHIMSY-343) Workbench request completes
incorrectly if mail fails
[ https://issues.apache.org/jira/browse/WHIMSY-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved WHIMSY-343.
-------------------------
Resolution: Fixed
This was caused by setting the disposition too late.
commit 4d3d6511722a3dd92a0ef2fd31ea16df2fe8ecd8
WHIMSY-343 - incorrect completion if mail fails
---
www/secretary/workbench/views/actions/pubkey.json.rb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
> Workbench request completes incorrectly if mail fails
> -----------------------------------------------------
>
> Key: WHIMSY-343
> URL: https://issues.apache.org/jira/browse/WHIMSY-343
> Project: Whimsy
> Issue Type: Bug
> Reporter: Sebb
> Priority: Major
>
> request to upload public key is treated as completed OK if sending the email fails and the user presses OK to the "Internal Server Error; continue?" prompt.
> However if the cancel button is pressed, pressing Resume works OK.
> Looks like the OK button is being handled as applying to the whole request, not just the email.
> Note: this was with Wunderbar 1.3.4
--
This message was sent by Atlassian Jira
(v8.3.4#803005)