You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Richard Ding (JIRA)" <ji...@apache.org> on 2011/03/22 23:30:05 UTC
[jira] [Created] (PIG-1931) Integrate Macro Expansion with New
Parser
Integrate Macro Expansion with New Parser
-----------------------------------------
Key: PIG-1931
URL: https://issues.apache.org/jira/browse/PIG-1931
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.6.0, 0.9.0
Reporter: Richard Ding
Assignee: Richard Ding
Fix For: 0.9.0
Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014721#comment-13014721 ]
Richard Ding commented on PIG-1931:
-----------------------------------
patch 4 committed to trunk.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch, PIG-1931_3.patch, PIG-1931_4.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1931:
------------------------------
Attachment: PIG-1931_2.patch
This patch added the script file name to the error messages and addressed the review comments.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1931:
------------------------------
Attachment: PIG-1931_4.patch
Attaching a simplified version. Thanks Xuefu for suggestions.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch, PIG-1931_3.patch, PIG-1931_4.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014274#comment-13014274 ]
Xuefu Zhang commented on PIG-1931:
----------------------------------
+1 PIG-1931_4.patch looks good.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch, PIG-1931_3.patch, PIG-1931_4.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011548#comment-13011548 ]
Xuefu Zhang commented on PIG-1931:
----------------------------------
+1 Patch PIG-1931_2.patch looks good. Additional comments:
1) The "main" pig script file name should be available from Antlr parser, which can be set in the AST node.
2) If not done already, please test cases where a macro def is called more than one time.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1931:
------------------------------
Affects Version/s: (was: 0.6.0)
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1931:
------------------------------
Attachment: PIG-1931_1.patch
Attaching the initial patch.
Still need to integrate file name, line number into the parser tree.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011335#comment-13011335 ]
Xuefu Zhang commented on PIG-1931:
----------------------------------
Some additional comments (It can be included in subsequent patches):
1. PigScriptParser.jj : multi assignment should cover the single assignment. No need to have both.
2. Need to add check to make sure that macro definition cannot happen in another macro definition.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013601#comment-13013601 ]
Xuefu Zhang commented on PIG-1931:
----------------------------------
Another observation: current the file name of the main script is set only on AST, so source file name will be there for errors reported by AST visitors or plan visitors. However, for syntax errors, which happen before AST tree is built, the file name is absent, which should be also part of error reporting.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014719#comment-13014719 ]
Richard Ding commented on PIG-1931:
-----------------------------------
test-patch result:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 8 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 556 release audit warnings (more than the trunk's current 555 warnings).
{code}
Release audit warning is html related.
Unit tests pass.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch, PIG-1931_3.patch, PIG-1931_4.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011515#comment-13011515 ]
Richard Ding commented on PIG-1931:
-----------------------------------
Patch 2 committed to trunk.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010899#comment-13010899 ]
Alan Gates commented on PIG-1931:
---------------------------------
Please make sure you post any results from your conversation here, so others can follow.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding resolved PIG-1931.
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
patches are committed to trunk.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch, PIG-1931_3.patch, PIG-1931_4.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010859#comment-13010859 ]
Xuefu Zhang commented on PIG-1931:
----------------------------------
I haven't finished reviewing (some code may require discussion in person), but here is my comments so far.
1. QueryParser.g
1) This file is for syntax check and AST generation. It's better to move the validation to one of the tree parsers.
2)For readability, please divide the long rules into sub-rules, each rule having only one root (^). Also, remove unnecessary token renaming such as rets+=alias.
3)Import and returns need to be added to eid (accross all tree parsers as well).
2. AliasMasker.g
1) Please simplify, be consistent with QueryParser.g, as you don't generate pig script any more. For instance,
output_clause
: ^( OUTPUT stream_cmd ( stream_cmd)* )
it should be just ^( OUTPUT stream_cmd+ )
3. QueryParserDriver.java
1)Error reporting should be consistent with others (especially line numbers and offsets)
2)I don't see how currentImport is updated anywhere.
3)In inlineMacro(), I don't see how nodes variable is updated. Isn't it always empty?
4. MacroExpansionDebug.g
1) pasted/copied code should be removed. For example, getErrorMessage()
2) I see a few unused member variables/methods.
3) File name is confusing. It seems having nothing to do with macro expansion. It just prints a script from an AST.
5. PigMacro.java
1)We should restrain from throwing runtime exception
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016538#comment-13016538 ]
Olga Natkovich commented on PIG-1931:
-------------------------------------
Can this ticket be closed?
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch, PIG-1931_3.patch, PIG-1931_4.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1931) Integrate Macro Expansion with New
Parser
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011476#comment-13011476 ]
Richard Ding commented on PIG-1931:
-----------------------------------
test-patch result:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 30 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] -1 javac. The applied patch generated 941 javac compiler warnings (more than the trunk's current 884 warnings).
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 550 release audit warnings (more than the trunk's current 548 warnings).
{code}
Release audit warnings are html related.
> Integrate Macro Expansion with New Parser
> -----------------------------------------
>
> Key: PIG-1931
> URL: https://issues.apache.org/jira/browse/PIG-1931
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-1931_1.patch, PIG-1931_2.patch
>
>
> Currently Macro expansion is implemented as a preprocessor (PIG-1793) so that it can work with the old parser. Now the new parser replaced old parser in trunk and we can integrate macro expansion into the new parser. This has many advantages such as better error reporting, less code and making Macro part of Pig Latin.
> To aid debugging, Pig command line option -r (dryrun) will produce a script with expanded macros (in addition to the script with substituted parameters).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira