You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/20 13:58:11 UTC
[GitHub] [skywalking] dmsolr opened a new pull request #4276: Provide AVRO
plugin
dmsolr opened a new pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
## Provide Avro plugin
checklist:
- [x] update component-libraries.yml
- [x] update supported-library.md
- [ ] add ico into skywalking-web
- [x] testcase
- [ ] unit test
## Screenshot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide
AVRO plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report
> Merging [#4276](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b552be49204301a6459fe9702511f5a4e20b0a6b?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `27.58%`.
[](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4276 +/- ##
==========================================
- Coverage 26.82% 26.79% -0.03%
==========================================
Files 1168 1168
Lines 25457 25457
Branches 3634 3634
==========================================
- Hits 6829 6822 -7
- Misses 18023 18030 +7
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `13.33% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...g/apm/plugin/avro/GenericRequestorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL0dlbmVyaWNSZXF1ZXN0b3JJbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...kywalking/oap/server/core/query/DurationUtils.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvRHVyYXRpb25VdGlscy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `73.04% <88.88%> (ø)` | :arrow_up: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=footer). Last update [b552be4...bc7c902](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4276: Provide AVRO
plugin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report
> Merging [#4276](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b552be49204301a6459fe9702511f5a4e20b0a6b?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `28.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4276 +/- ##
==========================================
- Coverage 26.82% 26.71% -0.11%
==========================================
Files 1168 1168
Lines 25457 25457
Branches 3634 3634
==========================================
- Hits 6829 6802 -27
- Misses 18023 18050 +27
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `13.33% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...kywalking/oap/server/core/query/DurationUtils.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvRHVyYXRpb25VdGlscy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `73.04% <88.88%> (ø)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `59.01% <0%> (-18.04%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `67.85% <0%> (-17.86%)` | :arrow_down: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `28.08% <0%> (-3.38%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `80.88% <0%> (-1.48%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=footer). Last update [b552be4...a3c4354](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide
AVRO plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@82cbbb8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4276 +/- ##
=========================================
Coverage ? 26.88%
=========================================
Files ? 1168
Lines ? 25457
Branches ? 3634
=========================================
Hits ? 6845
Misses ? 18006
Partials ? 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=footer). Last update [82cbbb8...9a26333](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4276: Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579733601
@dmsolr Avro test failing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4276: Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579544796
Please fix the icon related PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide
AVRO plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e609eca`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4276 +/- ##
=========================================
Coverage ? 26.88%
=========================================
Files ? 1168
Lines ? 25457
Branches ? 3634
=========================================
Hits ? 6845
Misses ? 18006
Partials ? 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=footer). Last update [e609eca...bf04731](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276:
Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#discussion_r372142601
##########
File path: test/plugin/scenarios/avro-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {avro-server: 2}
+ - {avro-client: 3}
+ instances:
+ - {avro-server: 1}
+ - {avro-client: 1}
+ operationNames:
+ - avro-server: [example.proto.Greeter.hello]
+ - avro-client: [/avro-scenario/case/healthCheck, /avro-scenario/case/avro-scenario]
+ heartbeat: []
+segmentItems:
+ - applicationCode: avro-server
+ segmentSize: 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: example.proto.Greeter.hello
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: RPCFramework
+ startTime: gt 0
+ endTime: gt 0
+ componentId: 82
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ refs:
+ - {parentEndpointId: 0, parentEndpoint: /avro-scenario/case/avro-scenario, networkAddressId: 0,
+ entryEndpointId: 0, refType: CrossProcess, parentSpanId: 1, parentTraceSegmentId: not null,
+ parentServiceInstanceId: 2, networkAddress: 'localhost/127.0.0.1:9018', entryEndpoint: /avro-scenario/case/avro-scenario,
+ entryServiceInstanceId: 2}
+ - applicationCode: avro-client
+ segmentSize: ge 2
+ segments:
+ - segmentId: not null
+ spans:
+ - {operationName: example.proto.Greeter.hello, operationId: 0, parentSpanId: 0,
Review comment:
Don't use this kind of format. Please change it to normal one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4276:
Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#discussion_r371233560
##########
File path: apm-sniffer/apm-sdk-plugin/avro-plugin/src/main/java/org/apache/skywalking/apm/plugin/avro/AbstractRequestInterceptor.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.avro;
+
+import java.io.IOException;
+import java.lang.reflect.Method;
+import org.apache.avro.Protocol;
+import org.apache.avro.ipc.Requestor;
+import org.apache.avro.ipc.Transceiver;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+
+public abstract class AbstractRequestInterceptor implements InstanceConstructorInterceptor, InstanceMethodsAroundInterceptor {
+ private static final ILog LOG = LogManager.getLogger(GenericRequestorInterceptor.class);
+
+ @Override
+ public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
+ if (objInst.getSkyWalkingDynamicField() == null) {
+ Requestor requestor = (Requestor)objInst;
+ requestor.addRPCPlugin(new SWClientRPCPlugin());
+
+ Protocol protocol = (Protocol)allArguments[0];
+ Transceiver transceiver = (Transceiver)allArguments[1];
+ try {
+ objInst.setSkyWalkingDynamicField(new AvroInstance(
+ protocol.getNamespace() + "." + protocol.getName() + ".",
+ transceiver.getRemoteName()
+ ));
+ } catch (IOException e) {
+ objInst.setSkyWalkingDynamicField(new AvroInstance("Undefined", "Undefined"));
+ LOG.error("", e);
Review comment:
Why empty string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276:
Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#discussion_r371221385
##########
File path: docs/en/setup/service-agent/java-agent/Supported-list.md
##########
@@ -41,6 +41,7 @@
* [Apache ServiceComb Java Chassis](https://github.com/apache/servicecomb-java-chassis) 0.1 -> 0.5,1.x
* [SOFARPC](https://github.com/alipay/sofa-rpc) 5.4.0
* [Armeria](https://github.com/line/armeria) 0.63.0 -> 0.97.0
+ * [Avro](http://avro.apache.org) 1.7.0 - 1.8.x
Review comment:
Use `Apache Avro`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide
AVRO plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report
> Merging [#4276](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9a2633374218366debd1f5c66b773a1ddc6fa4e3?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4276 +/- ##
==========================================
- Coverage 26.88% 26.77% -0.12%
==========================================
Files 1168 1168
Lines 25456 25465 +9
Branches 3633 3634 +1
==========================================
- Hits 6845 6818 -27
- Misses 18005 18041 +36
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/oap/query/graphql/resolver/MetricQuery.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldHJpY1F1ZXJ5LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [.../storage/plugin/jdbc/h2/dao/H2MetricsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc1F1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `59.01% <0%> (-18.04%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `67.85% <0%> (-17.86%)` | :arrow_down: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `28.08% <0%> (-3.38%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `80.88% <0%> (-1.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=footer). Last update [9a26333...95f6cda](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4276: Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4276: Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579305201
> One question, In `Avro` document, it is
>
> 1. Apache Avro™ is a data serialization system.
> 2. Remote procedure call (RPC).
>
> How does this PR works, if Avro is only working as a serialization tool only?
Yes, we support RPC only now. Don't have a plan to support the part of data serialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4276: Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579657894
Any issue or just unstable CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276:
Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#discussion_r372141227
##########
File path: apm-sniffer/apm-sdk-plugin/avro-plugin/src/main/java/org/apache/skywalking/apm/plugin/avro/AbstractRequestInterceptor.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.avro;
+
+import java.io.IOException;
+import java.lang.reflect.Method;
+import org.apache.avro.Protocol;
+import org.apache.avro.ipc.Requestor;
+import org.apache.avro.ipc.Transceiver;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+
+public abstract class AbstractRequestInterceptor implements InstanceConstructorInterceptor, InstanceMethodsAroundInterceptor {
+ private static final ILog LOG = LogManager.getLogger(GenericRequestorInterceptor.class);
Review comment:
LOG to logger? I remember most codes use this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276:
Provide AVRO plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#discussion_r372142050
##########
File path: apm-sniffer/apm-sdk-plugin/avro-plugin/src/main/java/org/apache/skywalking/apm/plugin/avro/SWClientRPCPlugin.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.avro;
+
+import org.apache.avro.ipc.RPCContext;
+import org.apache.avro.ipc.RPCPlugin;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+
+import java.nio.ByteBuffer;
+
+public class SWClientRPCPlugin extends RPCPlugin {
+
+ @Override
+ public void clientSendRequest(RPCContext context) {
+ if (ContextManager.isActive()) {
Review comment:
Is this check really meaningful? Such as in some cases, the context wouldn't be active? This Check is also a payload.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide
AVRO plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4276: Provide AVRO plugin
URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@82cbbb8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4276 +/- ##
=========================================
Coverage ? 26.88%
=========================================
Files ? 1168
Lines ? 25456
Branches ? 3633
=========================================
Hits ? 6845
Misses ? 18005
Partials ? 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=footer). Last update [82cbbb8...9a26333](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services