You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/23 16:13:19 UTC
[GitHub] [incubator-nuttx-apps] fjpanag opened a new pull request, #1382: Fixed compiler warnings.
fjpanag opened a new pull request, #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382
## Summary
Fixes a couple of compiler warnings.
## Impact
N/A
## Testing
Build test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002735010
##########
netutils/webclient/webclient.c:
##########
@@ -904,6 +906,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx,
static inline int wget_parsechunkenddata(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Let's move it after `ret = OK;`
##########
netutils/webclient/webclient.c:
##########
@@ -794,6 +795,7 @@ static inline int wget_parseheaders(struct webclient_context *ctx,
static inline int wget_parsechunkheader(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Let's move it after `ret = OK:`
##########
netutils/webclient/webclient.c:
##########
@@ -1873,7 +1877,7 @@ int webclient_perform(FAR struct webclient_context *ctx)
DEBUGASSERT(bytes_to_send <= ws->state_len);
ssize_t ssz = webclient_conn_send(conn,
- ws->data_buffer +
+ (char*)ws->data_buffer +
Review Comment:
```suggestion
(char *)ws->data_buffer +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002740169
##########
netutils/webclient/webclient.c:
##########
@@ -1873,7 +1877,7 @@ int webclient_perform(FAR struct webclient_context *ctx)
DEBUGASSERT(bytes_to_send <= ws->state_len);
ssize_t ssz = webclient_conn_send(conn,
- ws->data_buffer +
+ (char*)ws->data_buffer +
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002769220
##########
netutils/webclient/webclient.c:
##########
@@ -797,6 +798,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx,
int offset;
int ndx;
int ret = OK;
+ UNUSED(ctx);
Review Comment:
done
##########
netutils/webclient/webclient.c:
##########
@@ -907,6 +909,7 @@ static inline int wget_parsechunkenddata(struct webclient_context *ctx,
int offset;
int ndx;
int ret = OK;
+ UNUSED(ctx);
Review Comment:
done
##########
netutils/webclient/webclient.c:
##########
@@ -965,6 +968,7 @@ static inline int wget_parsechunktrailer(struct webclient_context *ctx,
int offset;
int ndx;
int ret = OK;
+ UNUSED(ctx);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002764169
##########
netutils/webclient/webclient.c:
##########
@@ -965,6 +968,7 @@ static inline int wget_parsechunktrailer(struct webclient_context *ctx,
int offset;
int ndx;
int ret = OK;
+ UNUSED(ctx);
Review Comment:
```suggestion
UNUSED(ctx);
```
##########
netutils/webclient/webclient.c:
##########
@@ -907,6 +909,7 @@ static inline int wget_parsechunkenddata(struct webclient_context *ctx,
int offset;
int ndx;
int ret = OK;
+ UNUSED(ctx);
Review Comment:
```suggestion
UNUSED(ctx);
```
##########
netutils/webclient/webclient.c:
##########
@@ -797,6 +798,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx,
int offset;
int ndx;
int ret = OK;
+ UNUSED(ctx);
Review Comment:
```suggestion
UNUSED(ctx);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002740068
##########
netutils/webclient/webclient.c:
##########
@@ -904,6 +906,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx,
static inline int wget_parsechunkenddata(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Done.
##########
netutils/webclient/webclient.c:
##########
@@ -794,6 +795,7 @@ static inline int wget_parseheaders(struct webclient_context *ctx,
static inline int wget_parsechunkheader(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1382: Fixed compiler warnings.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#issuecomment-1288384476
Let's ignore the know ci broken issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org