Significant Advanced Datagrid performance improvement

[Justin Mclean <ju...@classsoftware.com>]

Hi,

I was look at the ADG with advanced telemetry and notice as issue with get columns and garbage collection and come up with a reasonably simple fix.

https://issues.apache.org/jira/browse/FLEX-33682

The fix for it significantly improves ADG performance (much more that I thought it would), depending on the number of columns, rows etc and from what I've seen it can be up to twice as quick, and for some operations eg sorting columns and horizontal scrolling the speed improvement is even better than that. In some case I'd estimate that it's going to have an order of magnitude speed increase over Apache Flex 4.9.

Can someone else try it out in their project and tell me what they see in terms of performance increase.

Is this worth a point release or should we just point people to the nightly build?

Enjoy!
Justin

Re: Significant Advanced Datagrid performance improvement

[Alex Harui <ah...@adobe.com>]

On 8/26/13 10:42 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:

>Hi,
>
>> Excellent!  I'm a bit concerned about exposing it publicly because if
>> folks manipulate the array instead of a clone things can go funky but
>> having the internals get the low-level array sounds like the right
>>thing.
>
>I could put it in the mx_internal namesapace rather than public but
>that's still doesn't stop people from abusing it if they want to.
That and/or call it "lookButDontTouchColumns" ;-)
>
>the speed increase is significant so it's worth some risk IMO.
Agreed.

-Alex

Re: Significant Advanced Datagrid performance improvement

[Justin Mclean <ju...@classsoftware.com>]

Hi,

> Excellent!  I'm a bit concerned about exposing it publicly because if
> folks manipulate the array instead of a clone things can go funky but
> having the internals get the low-level array sounds like the right thing.

I could put it in the mx_internal namesapace rather than public but that's still doesn't stop people from abusing it if they want to.

the speed increase is significant so it's worth some risk IMO.

Thanks,
Justin

Re: Significant Advanced Datagrid performance improvement

[Alex Harui <ah...@adobe.com>]

On 8/26/13 9:35 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:

>Hi,
>
>I was look at the ADG with advanced telemetry and notice as issue with
>get columns and garbage collection and come up with a reasonably simple
>fix.
>
>https://issues.apache.org/jira/browse/FLEX-33682
>
>The fix for it significantly improves ADG performance (much more that I
>thought it would), depending on the number of columns, rows etc and from
>what I've seen it can be up to twice as quick, and for some operations eg
>sorting columns and horizontal scrolling the speed improvement is even
>better than that. In some case I'd estimate that it's going to have an
>order of magnitude speed increase over Apache Flex 4.9.
Excellent!  I'm a bit concerned about exposing it publicly because if
folks manipulate the array instead of a clone things can go funky but
having the internals get the low-level array sounds like the right thing.

>
>Is this worth a point release or should we just point people to the
>nightly build?
I think we have a number of other issues to work through (some DG issue
with states, a chart styles/modules thing, the comparable for Java 7).
Then maybe it will be time for 4.11.

-Alex