[GitHub] [beam] chamikaramj commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r409024858
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery.py
 ##########
 @@ -669,6 +681,13 @@ def estimate_size(self):
       # no access to the query that we're running.
       return None
 
+  def _create_source(self, path, schema):
+    if not self.use_json_exports:
+      return create_avro_source(path, 0, True, use_fastavro=True)
 
 Review comment:
   Probably cleaner to use the "param_name=value" format here for keyword arguments and not specify anything when we just want the default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services