[GitHub] [knox] shawnweeks commented on a change in pull request #75: KNOX-1828 Fix Websocket Message Size

[GitBox <gi...@apache.org>]

shawnweeks commented on a change in pull request #75: KNOX-1828 Fix Websocket Message Size
URL: https://github.com/apache/knox/pull/75#discussion_r266447454
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
 ##########
 @@ -87,6 +87,8 @@ public void onWebSocketConnect(final Session frontEndSession) {
      * plumbing takes place
      */
     container = ContainerProvider.getWebSocketContainer();
+    container.setDefaultMaxBinaryMessageBufferSize(Integer.MAX_VALUE);
+    container.setDefaultMaxTextMessageBufferSize(Integer.MAX_VALUE);
 
 Review comment:
   I can grab those from the frontEndSession. Originally I was trying to figure out how to just set the policy on the container but as far as I can tell Jetty doesn't provide a good way to do that. The backendSession is still use Integer.MAX_VALUE from another effort. Should I try to set it as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services