You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jess Garms (JIRA)" <ji...@apache.org> on 2013/03/20 18:57:15 UTC

[jira] [Created] (GIRAPH-576) BspServiceMaster.failureCleanup() shouldn't pass null in observers' applicationFailed() method

Jess Garms created GIRAPH-576:
---------------------------------

             Summary: BspServiceMaster.failureCleanup() shouldn't pass null in observers' applicationFailed() method
                 Key: GIRAPH-576
                 URL: https://issues.apache.org/jira/browse/GIRAPH-576
             Project: Giraph
          Issue Type: Bug
          Components: bsp
    Affects Versions: 0.2.0
         Environment: Linux
            Reporter: Jess Garms
            Priority: Minor
             Fix For: 0.2.0


failureCleanup() in BspServiceMaster gets called with a null exception from failJob(). That in turn passes a null exception to the set of MasterObservers, in their applicationFailed() method. They probably aren't expecting that. Instead we should pass an appropriate exception around depending on the cause of the failure.

I'll attach a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira