You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/07 20:37:17 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #13405: [BEAM-10703, BEAM-10475] Add GroupIntoBatches to runner API; add Dataflow override in Python SDK

chamikaramj commented on a change in pull request #13405:
URL: https://github.com/apache/beam/pull/13405#discussion_r537815112



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1112,6 +1128,17 @@ def run_ParDo(self, transform_node, options):
       if is_stateful_dofn:
         step.add_property(PropertyNames.USES_KEYED_STATE, 'true')
 
+        # Also checks whether the step allows shardable keyed states.
+        for pcoll in transform_node.outputs.values():

Review comment:
       https://issues.apache.org/jira/browse/BEAM-11360 for Python. Java does not need cleanups but need to be updated to use portable job submission which is tracked separately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org