You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/03/07 14:13:43 UTC

[GitHub] flink pull request #5657: [FLINK-8887][tests] Add single retry in MiniCluste...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5657

    [FLINK-8887][tests] Add single retry in MiniClusterClient

    ## What is the purpose of the change
    
    This PR presents a test workaround for race-conditions in FLIP-6 (most notably FLINK-8887). Basically, every `MiniClusterClient` call is retried *once* after 500ms in case of certain exceptions.
    
    **This is only a band-aid until a proper fix is in place** so we can finally continue merging more test ports.
    
    ## Brief change log
    
    * add `guardWithSingleRetry` convenience method
    * add `ScheduledExecutor` to `MiniClusterClient`
    * guard all calls to the `MiniCluster`
    
    ## Verifying this change
    
    The change can be verified by cherry-picking [this branch](https://github.com/zentol/flink/tree/8797) and running the `AbstractOperatorRestoreTestBase`. Before this change there was always 1-2 tests failing, whereas now none should fail.
    
    /cc @aljoscha @GJL 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8887_bandaid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5657.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5657
    
----
commit f685fad6731b7c1774b247985a446260ea285663
Author: zentol <ch...@...>
Date:   2018-03-07T14:02:05Z

    [FLINK-8887][tests] Add single retry in MiniClusterClient

----


---

[GitHub] flink pull request #5657: [FLINK-8887][tests] Add single retry in MiniCluste...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5657


---

[GitHub] flink issue #5657: [FLINK-8887][tests] Add single retry in MiniClusterClient

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5657
  
    merging.


---

[GitHub] flink issue #5657: [FLINK-8887][tests] Add single retry in MiniClusterClient

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5657
  
    +1 I think this makes sense if it unblocks merging test ports to master. I'm guessing we'll leave FLINK-8887 open until we have the proper fix?


---