You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gopidesupavan (via GitHub)" <gi...@apache.org> on 2024/04/28 23:33:45 UTC
[PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
gopidesupavan opened a new pull request, #39300:
URL: https://github.com/apache/airflow/pull/39300
This PR is to add the additional parameters to aws lambdacreatefunctionoperator.
The following parameters are added.
EphemeralStorage: To set the size of function /tmp directory.
SnapStart: To create a snapshot of the initialized execution environment when you publish a function version.
LoggingConfig: AWS cloudwatch log configuration settings. By default, Lambda functions send logs to a default log group named /aws/lambda/<function name>. To use a different log group, use this loggingconfig.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #39300:
URL: https://github.com/apache/airflow/pull/39300#discussion_r1582533396
##########
airflow/providers/amazon/aws/hooks/lambda_function.py:
##########
@@ -106,6 +106,9 @@ def create_lambda(
image_config: Any | None = None,
code_signing_config_arn: str | None = None,
architectures: list[str] | None = None,
+ ephemeral_storage: Any | None = None,
Review Comment:
Can this be Any? Or should we have a proper type and define a default as well?
##########
tests/providers/amazon/aws/operators/test_lambda_function.py:
##########
@@ -125,6 +125,38 @@ def test_create_lambda_deferrable(self, _):
with pytest.raises(TaskDeferred):
operator.execute(None)
+ @mock.patch.object(LambdaHook, "create_lambda")
+ @mock.patch.object(LambdaHook, "conn")
+ @pytest.mark.parametrize(
+ "config",
+ [
+ pytest.param({"architectures": ["arm64"],
+ "logging_config": {
+ "LogFormat": "Text",
+ "LogGroup": "/custom/log-group/"
+ }
+ }, id="with-config-argument"),
+ ],
+ )
+ def test_create_lambda_using_config_argument(self,
+ mock_hook_conn,
+ mock_hook_create_lambda, config):
+ operator = LambdaCreateFunctionOperator(
+ task_id="task_test",
+ function_name=FUNCTION_NAME,
+ role=ROLE_ARN,
+ code={
+ "ImageUri": IMAGE_URI,
+ },
+ config=config
+ )
+ operator.execute(None)
+
+ mock_hook_create_lambda.assert_called_once()
+ mock_hook_conn.get_waiter.assert_not_called()
+ assert operator.config.get("logging_config") == config.get("logging_config")
+ assert operator.config.get("architectures") == config.get("architectures")
+
Review Comment:
Can you add cases for other configs like snap_start and ephemeral_storage as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #39300:
URL: https://github.com/apache/airflow/pull/39300#issuecomment-2081698614
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #39300:
URL: https://github.com/apache/airflow/pull/39300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #39300:
URL: https://github.com/apache/airflow/pull/39300#discussion_r1584119676
##########
airflow/providers/amazon/aws/hooks/lambda_function.py:
##########
@@ -106,6 +106,9 @@ def create_lambda(
image_config: Any | None = None,
code_signing_config_arn: str | None = None,
architectures: list[str] | None = None,
+ ephemeral_storage: Any | None = None,
Review Comment:
I see, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #39300:
URL: https://github.com/apache/airflow/pull/39300#issuecomment-2087171242
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #39300:
URL: https://github.com/apache/airflow/pull/39300#discussion_r1582573663
##########
tests/providers/amazon/aws/operators/test_lambda_function.py:
##########
@@ -125,6 +125,38 @@ def test_create_lambda_deferrable(self, _):
with pytest.raises(TaskDeferred):
operator.execute(None)
+ @mock.patch.object(LambdaHook, "create_lambda")
+ @mock.patch.object(LambdaHook, "conn")
+ @pytest.mark.parametrize(
+ "config",
+ [
+ pytest.param({"architectures": ["arm64"],
+ "logging_config": {
+ "LogFormat": "Text",
+ "LogGroup": "/custom/log-group/"
+ }
+ }, id="with-config-argument"),
+ ],
+ )
+ def test_create_lambda_using_config_argument(self,
+ mock_hook_conn,
+ mock_hook_create_lambda, config):
+ operator = LambdaCreateFunctionOperator(
+ task_id="task_test",
+ function_name=FUNCTION_NAME,
+ role=ROLE_ARN,
+ code={
+ "ImageUri": IMAGE_URI,
+ },
+ config=config
+ )
+ operator.execute(None)
+
+ mock_hook_create_lambda.assert_called_once()
+ mock_hook_conn.get_waiter.assert_not_called()
+ assert operator.config.get("logging_config") == config.get("logging_config")
+ assert operator.config.get("architectures") == config.get("architectures")
+
Review Comment:
Thank you @amoghrajesh Yes i have updated the TC now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added logging_config,snapstart,ephemeral_storage parameters to aws lambdacreatefunctionoperator [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #39300:
URL: https://github.com/apache/airflow/pull/39300#discussion_r1582573457
##########
airflow/providers/amazon/aws/hooks/lambda_function.py:
##########
@@ -106,6 +106,9 @@ def create_lambda(
image_config: Any | None = None,
code_signing_config_arn: str | None = None,
architectures: list[str] | None = None,
+ ephemeral_storage: Any | None = None,
Review Comment:
Hi @amoghrajesh , Basically the added parameters are dict as per boto3 configuration, Here there are already few dict parameters defined as Any, I have followed the similar approach for these new parameters.
And the default is set to None because there is call to trim the none values, Before creating function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org