[GitHub] ahgittin commented on a change in pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit

[GitBox <gi...@apache.org>]

ahgittin commented on a change in pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit
URL: https://github.com/apache/brooklyn-ui/pull/124#discussion_r261221073
 
 

 ##########
 File path: ui-modules/blueprint-composer/app/components/dsl-viewer/dsl-viewer.template.html
 ##########
 @@ -46,6 +48,10 @@
             <dsl-viewer dsl="argument"></dsl-viewer>
         </li>
     </ol>
-</span>
+  </span>
 
-<span ng-if="isLiteralDsl(dsl)">{{dsl.name}}</span>
\ No newline at end of file
+  <span ng-switch-default>
+    {{ getMode(dsl) }}: {{ dsl }}
 
 Review comment:
   in this default case we do _not_ have an icon so i think this is the right way to do it (but i don't think we have any default cases anymore so it's moot)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services