You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2022/08/16 11:28:00 UTC
[jira] [Resolved] (OMID-229) Allow only "squash and merge" from GitHub UI
[ https://issues.apache.org/jira/browse/OMID-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Istvan Toth resolved OMID-229.
------------------------------
Fix Version/s: 1.0.3
Resolution: Fixed
Committed to master.
Thanks for the review [~richardantal] .
> Allow only "squash and merge" from GitHub UI
> --------------------------------------------
>
> Key: OMID-229
> URL: https://issues.apache.org/jira/browse/OMID-229
> Project: Phoenix Omid
> Issue Type: Bug
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 1.0.3
>
>
> Github has three possible merging modes from the UI:
> [https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges]
> Of those, we want "squash and merge" 99% of the time, but sometimes other methods are chosen, resulting in a less than ideal commit graph.
> This is configurable via .asf.yml :
> [https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Mergebuttons]
> I propose that we disable the "merge" and "rebase" options for every Phoenix repo via the .asf.yml file.
> This only applies to the GitHub Web UI, the other methods can still be used via the standard git operations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)