You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/27 07:10:34 UTC
[GitHub] [bookkeeper] gaozhangmin opened a new pull request #2808: set response body when return ok
gaozhangmin opened a new pull request #2808:
URL: https://github.com/apache/bookkeeper/pull/2808
API `/api/v1/bookie/is_ready` should set some response body, when code 200 returned.
Or, this will confuse people, they don't know if this api return successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2808: set response body for bookie is_ready api
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2808:
URL: https://github.com/apache/bookkeeper/pull/2808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2808: set response body for bookie is_ready api
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2808:
URL: https://github.com/apache/bookkeeper/pull/2808#issuecomment-929028378
@dlg99 please help rerun failed tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2808: set response body for bookie is_ready api
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2808:
URL: https://github.com/apache/bookkeeper/pull/2808#discussion_r716472857
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/BookieIsReadyService.java
##########
@@ -51,7 +51,7 @@ public HttpServiceResponse handle(HttpServiceRequest request) throws Exception {
StateManager sm = bookie.getStateManager();
if (sm.isRunning() && !sm.isShuttingDown()) {
response.setCode(HttpServer.StatusCode.OK);
- response.setBody("");
+ response.setBody("Bookie is fully started.");
Review comment:
What about a simple 'OK'?
Not a big deal.
BTW, can you update/add the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2808: set response body for bookie is_ready api
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2808:
URL: https://github.com/apache/bookkeeper/pull/2808#issuecomment-927571698
@dlg99 @eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2808: set response body for bookie is_ready api
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2808:
URL: https://github.com/apache/bookkeeper/pull/2808#issuecomment-929028378
@dlg99 please help rerun failed tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org