[Bug 8096] New: t/strip2.t fails if Text::Diff is not installed

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8096

            Bug ID: 8096
           Summary: t/strip2.t fails if Text::Diff is not installed
           Product: Spamassassin
           Version: 4.0.0
          Hardware: PC
                OS: Windows 10
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Regression Tests
          Assignee: dev@spamassassin.apache.org
          Reporter: spamassassinbugs_peep@parallaxshift.com
  Target Milestone: Undefined

Created attachment 5870
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5870&action=edit
Patch to strip2.t that disables it if Text::Diff is not available

strip2.t depends upon Text::Diff (and the test appears to be the only code that
uses that module).

It needs skip_all protection like the other tests which depend upon
non-documented external packages so it'll self disable.

==================================================================
use constant HAS_TEXTDIFF => eval { require Text::Diff; };

plan skip_all => 'Need Text::Diff' unless HAS_TEXTDIFF;
==================================================================

... and remove the "use Text::Diff" line.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8096] t/strip2.t fails if Text::Diff is not installed

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8096

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
                 CC|                            |billcole@apache.org
                 OS|Windows 10                  |All

--- Comment #1 from Bill Cole <bi...@apache.org> ---
Thanks for the report and the patch. 

This appears to have been missed in the past because historically Text::Diff
was an indirect dependency via Mail::Audit, which early versions of SA required
and MIME-Tools, which many mail systems also have installed. 

Fix committed in r1906233.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8096] t/strip2.t fails if Text::Diff is not installed

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8096

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Bill Cole <bi...@apache.org> ---
fixed in r1906233

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8096] t/strip2.t fails if Text::Diff is not installed

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8096

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |4.0.1
                 CC|                            |sidney@sidney.com

-- 
You are receiving this mail because:
You are the assignee for the bug.