[GitHub] [tvm] Lunderberg opened a new pull request, #14570: [LLVM] Use Var annotation in LetStmt for pointer type

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg opened a new pull request, #14570:
URL: https://github.com/apache/tvm/pull/14570

   TIR has type-annotations on variables, but not on each PrimExpr. Because some versions of LLVM (before LLVM 15) default to using typed pointers, passing LLVM validation may require correct pointer types. This is typically encountered in unpacking of PackedFunc arguments, where the LLVM type of a data array must be cast from `i8*` to a pointer to the buffer type.  These pointer-to-pointer casts are not expressible in TIR, because the `tir::CastNode` represents all pointers as `DataType::Handle()`, and so must be handled during codegen instead of earlier in the lowering flow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14570: [LLVM] Use Var annotation in LetStmt for pointer type

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #14570:
URL: https://github.com/apache/tvm/pull/14570#issuecomment-1502333931

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `llvm` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org