You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by zzcclp <gi...@git.apache.org> on 2017/12/01 06:17:13 UTC

[GitHub] carbondata pull request #1600: [CARBONDATA-1842]Fix 'wrong argument number' ...

GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/1600

    [CARBONDATA-1842]Fix 'wrong argument number' error of class Cast for Spark 2.2 when pattern matching

    In class 'org.apache.spark.sql.hive.CarbonPreAggregateQueryRules', there is an 'wrong argument number' error of class 'org.apache.spark.sql.catalyst.expressions.Cast' when compile with Spark 2.2, because the constructor of class org.apache.spark.sql.catalyst.expressions.Cast has two arguments in Spark 2.1, but it needs three arguments in Spark 2.2.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata CARBONDATA-1842

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1600
    
----
commit b7e8a4126f14b8efa3c7afe8b230fb1032ecea72
Author: Zhang Zhichao <44...@qq.com>
Date:   2017-12-01T06:13:33Z

    [CARBONDATA-1842]Fix 'wrong argument number' error of class Cast for Spark 2.2 when pattern matching
    
    In class 'org.apache.spark.sql.hive.CarbonPreAggregateQueryRules', there is an 'wrong argument number' error of class 'org.apache.spark.sql.catalyst.expressions.Cast' when compile with Spark 2.2, because the constructor of class org.apache.spark.sql.catalyst.expressions.Cast has two arguments in Spark 2.1, but it needs three arguments in Spark 2.2.

----


---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    resolved by #1508


---

[GitHub] carbondata pull request #1600: [CARBONDATA-1842]Fix 'wrong argument number' ...

Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp closed the pull request at:

    https://github.com/apache/carbondata/pull/1600


---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2015/



---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1624/



---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    I have tested successfully with below commands:
    1. mvn -DskipTests -Pspark-2.2 -Phadoop-2.2.0 -Pbuild-with-format -Dspark.version=2.2.0 -Dhadoop.version=2.6.0-cdh5.7.1 clean package
    2. mvn -Pspark-2.1 -Phadoop-2.2.0 -Pbuild-with-format -Dspark.version=2.1.2 -Dhadoop.version=2.6.0-cdh5.7.1 clean package
    
    



---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    @zzcclp I have already handled this in #1508. 
    a new Expression is already defined by @sounakr which will take care of the Cast compatibility between spark-2.1 and spark-2.2



---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    ok, i close this pr


---

[GitHub] carbondata issue #1600: [CARBONDATA-1842]Fix 'wrong argument number' error o...

Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1600
  
    After  merging PR #1542 , there is 'wrong argument number' error in CarbonPreAggregateQueryRules when profile of spark-2.2 is active .
    @kunal642 , @jackylk , @sounakr , please check this. thanks.


---